From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers:lcd: fix unaligned access on lcd
Date: Tue, 28 May 2013 09:10:57 +0300 [thread overview]
Message-ID: <51A44A71.8080502@compulab.co.il> (raw)
In-Reply-To: <000301ce5ace$42b00dc0$c8102940$%wilczek@samsung.com>
Hi Piotr,
On 05/27/2013 02:35 PM, Piotr Wilczek wrote:
> Dear Wolfgang Denk,
>
>> -----Original Message-----
>> From: Wolfgang Denk [mailto:wd at denx.de]
>> Sent: Friday, May 24, 2013 8:33 PM
>> To: Piotr Wilczek
>> Cc: u-boot at lists.denx.de; Kyungmin Park
>> Subject: Re: [U-Boot] [PATCH] drivers:lcd: fix unaligned access on lcd
>>
[...]
>
> My case is a bmp unzipped to a 4-byte aligned address. The two signature bytes of the bmp header make the other fields 4-byte unaligned. We could force unzip the bmp to an aligned address + 2.
>
> Is this a better solution?
That is the solution we settled on the last time this was discussed.
See CONFIG_SPLASHIMAGE_GUARD in the README file if your use case
involves user input, or just pick an aligned address + 2 in your code.
--
Regards,
Nikita.
next prev parent reply other threads:[~2013-05-28 6:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 7:46 [U-Boot] [PATCH] drivers:lcd: fix unaligned access on lcd Piotr Wilczek
2013-05-24 18:33 ` Wolfgang Denk
2013-05-27 11:35 ` Piotr Wilczek
2013-05-28 6:10 ` Nikita Kiryanov [this message]
2013-05-24 18:41 ` Jeroen Hofstee
2013-05-31 11:26 ` [U-Boot] [PATCH] lcd: align bmp header when uncopmressing image Piotr Wilczek
2013-05-31 14:22 ` Wolfgang Denk
2013-06-03 6:17 ` Piotr Wilczek
2013-06-03 11:15 ` Wolfgang Denk
2013-06-03 14:14 ` Piotr Wilczek
2013-06-03 18:45 ` Wolfgang Denk
2013-06-02 11:05 ` Nikita Kiryanov
2013-06-03 6:39 ` Piotr Wilczek
2013-06-03 11:18 ` Wolfgang Denk
2013-06-03 13:59 ` [U-Boot] [PATCH V2] " Piotr Wilczek
2013-06-03 18:44 ` Wolfgang Denk
2013-06-04 11:00 ` [U-Boot] [PATCH V3] " Piotr Wilczek
2013-06-04 15:05 ` Wolfgang Denk
2013-06-05 6:14 ` [U-Boot] [PATCH V4] " Piotr Wilczek
2013-07-01 18:51 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A44A71.8080502@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.