From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Eric Dumazet <erdnetdev@gmail.com>
Cc: Dave Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net,
Willem de Bruijn <willemb@google.com>,
Andi Kleen <andi@firstfloor.org>, HPA <hpa@zytor.com>,
Eilon Greenstien <eilong@broadcom.com>,
Or Gerlitz <or.gerlitz@gmail.com>,
Alex Rosenbaum <alexr@mellanox.com>,
Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v5 net-next 1/5] net: add napi_id and hash
Date: Tue, 28 May 2013 11:03:05 +0300 [thread overview]
Message-ID: <51A464B9.5080106@linux.intel.com> (raw)
In-Reply-To: <1369700905.3301.499.camel@edumazet-glaptop>
On 28/05/2013 03:28, Eric Dumazet wrote:
> On Mon, 2013-05-27 at 10:44 +0300, Eliezer Tamir wrote:
>> +extern void napi_hash_add(struct napi_struct *napi);
>> +
>> +/**
>> + * napi_hash_del - remove a NAPI from blobal table
>
> global
Thank you
(my typing is almost as bad as my spelling, please don't tell my mom)
>> @@ -166,6 +167,10 @@ static struct list_head offload_base __read_mostly;
>> DEFINE_RWLOCK(dev_base_lock);
>> EXPORT_SYMBOL(dev_base_lock);
>>
>> +atomic_t napi_gen_id;
>
> Not sure we need an atomic, we are protected by RTNL anyway.
With an atomic we don't need the RTNL in any of the napi_id functions.
One less thing to worry about when we try to remove the RTNL.
-Eliezer
next prev parent reply other threads:[~2013-05-28 8:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 7:43 [PATCH v5 net-next 0/5] net: low latency Ethernet device polling Eliezer Tamir
2013-05-27 7:44 ` [PATCH v5 net-next 1/5] net: add napi_id and hash Eliezer Tamir
2013-05-27 7:44 ` Eliezer Tamir
2013-05-28 0:28 ` Eric Dumazet
2013-05-28 8:03 ` Eliezer Tamir [this message]
2013-05-28 13:38 ` Eric Dumazet
2013-05-28 13:38 ` Eric Dumazet
2013-05-28 13:41 ` Eliezer Tamir
2013-05-27 7:44 ` [PATCH v5 net-next 2/5] net: implement support for low latency socket polling Eliezer Tamir
2013-05-27 7:44 ` Eliezer Tamir
2013-05-28 0:26 ` Eric Dumazet
2013-05-28 0:26 ` Eric Dumazet
2013-05-28 8:04 ` Eliezer Tamir
2013-05-27 7:44 ` [PATCH v5 net-next 3/5] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-27 7:44 ` Eliezer Tamir
2013-05-28 0:36 ` Eric Dumazet
2013-05-28 8:26 ` Eliezer Tamir
2013-05-28 12:15 ` Eliezer Tamir
2013-05-28 13:44 ` Eric Dumazet
2013-05-28 13:44 ` Eric Dumazet
2013-05-27 7:44 ` [PATCH v5 net-next 4/5] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-27 7:44 ` Eliezer Tamir
2013-05-27 7:44 ` [PATCH v5 net-next 5/5] ixgbe: add extra stats " Eliezer Tamir
2013-05-28 0:35 ` [PATCH v5 net-next 0/5] net: low latency Ethernet device polling Eric Dumazet
2013-05-28 0:35 ` Eric Dumazet
2013-05-28 8:29 ` Eliezer Tamir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A464B9.5080106@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=alexr@mellanox.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer@tamir.org.il \
--cc=erdnetdev@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.