From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 28 May 2013 10:08:40 +0200 Subject: [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout In-Reply-To: References: Message-ID: <51A46608.2020906@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15/05/2013 11:37, David Laight : >> From: Havard Skinnemoen > >> Move the NAPI struct below that since it is used >> from the interrupt handler. This field is also marked as >> ___cacheline_aligned_in_smp. > > Is that a good idea if the cache line size is 256 bytes? > Indeed is that ever sane - except for a few special structures > that really need it, and are guaranteed to be allocated > with that much alignment. I do not know if that was really needed, it was a recommendation by Ben. (previous email here: https://patchwork.kernel.org/patch/1887101/ ) Anyway, it seems that this patch needs more work whereas the others of the series are not commented. So maybe, I can resend patches 1, 2 for making this big enhancement go forward (as it is in review process for quite a long time...). David, do you want me to resend or can you retrieve these v3 patches in patchwork? Best regards, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933403Ab3E1IIr (ORCPT ); Tue, 28 May 2013 04:08:47 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:52260 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933327Ab3E1IIp (ORCPT ); Tue, 28 May 2013 04:08:45 -0400 Message-ID: <51A46608.2020906@atmel.com> Date: Tue, 28 May 2013 10:08:40 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: David Laight , "David S. Miller" , CC: , , Jean-Christophe PLAGNIOL-VILLARD , , , , , Havard Skinnemoen , Ben Hutchings Subject: Re: [PATCH 3/3 v3] net/macb: Try to optimize struct macb layout References: In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/05/2013 11:37, David Laight : >> From: Havard Skinnemoen > >> Move the NAPI struct below that since it is used >> from the interrupt handler. This field is also marked as >> ___cacheline_aligned_in_smp. > > Is that a good idea if the cache line size is 256 bytes? > Indeed is that ever sane - except for a few special structures > that really need it, and are guaranteed to be allocated > with that much alignment. I do not know if that was really needed, it was a recommendation by Ben. (previous email here: https://patchwork.kernel.org/patch/1887101/ ) Anyway, it seems that this patch needs more work whereas the others of the series are not commented. So maybe, I can resend patches 1, 2 for making this big enhancement go forward (as it is in review process for quite a long time...). David, do you want me to resend or can you retrieve these v3 patches in patchwork? Best regards, -- Nicolas Ferre