From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhGfQ-0004AE-8L for qemu-devel@nongnu.org; Tue, 28 May 2013 05:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhGfM-0007bL-91 for qemu-devel@nongnu.org; Tue, 28 May 2013 05:58:08 -0400 Message-ID: <51A47FA5.8080406@redhat.com> Date: Tue, 28 May 2013 11:57:57 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1369722844-24345-1-git-send-email-kraxel@redhat.com> <1369722844-24345-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1369722844-24345-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Anthony Liguori , "qemu-stable@nongnu.org" , qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On 05/28/13 08:34, Gerd Hoffmann wrote: > Fill unset CharDriverState->filename with the backend name, so > 'info chardev' will return at least the chardev type. Don't > touch it in case the chardev init function filled it already, > like the socket+pty chardevs do for example. > > Signed-off-by: Gerd Hoffmann > --- > qemu-char.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index f825294..d04b429 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3801,6 +3801,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend, > chr->label = g_strdup(id); > chr->avail_connections = > (backend->kind == CHARDEV_BACKEND_KIND_MUX) ? MAX_MUX : 1; > + if (!chr->filename) { > + chr->filename = g_strdup(ChardevBackendKind_lookup[backend->kind]); > + } > QTAILQ_INSERT_TAIL(&chardevs, chr, next); > return ret; > } else { > this one is a stable candidate, cc'ing qemu-stable cheers, Gerd