All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dracut systemd cmdline service fix
Date: Tue, 28 May 2013 12:53:54 +0200	[thread overview]
Message-ID: <51A48CC2.40500@redhat.com> (raw)
In-Reply-To: <51946b65.1SfwJA0QAkY6Gb83%dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 05/16/2013 07:15 AM, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote:
> 
> Kdump test failed since below commits 
> dbfaae0e34507d2d1f3c186ffe26af3e8028b9f8
> 
> Fedora bug is here:
> https://bugzilla.redhat.com/show_bug.cgi?id=963159
> 
> The reason is the hooks afterwards need NEWROOT env which
> is set in dracut-cmdline.sh.
> 
> In this case there's no files under /etc/cmdline.d/ and
> /lib/dracut/hooks/cmdline/. Conditions checking failed, so
> the cmdline service failed to startup.
> 
> Fix this issue by remove the Conditions thus cmdline service
> always run if /etc/initrd-release exists.
> 
> Signed-off-by: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  modules.d/98systemd/dracut-cmdline.service |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- dracut.orig/modules.d/98systemd/dracut-cmdline.service
> +++ dracut/modules.d/98systemd/dracut-cmdline.service
> @@ -16,11 +16,6 @@ Before=systemd-vconsole-setup.service
>  After=systemd-journald.socket
>  Wants=systemd-journald.socket
>  ConditionPathExists=/etc/initrd-release
> -ConditionPathExistsGlob=|/etc/cmdline.d/*.conf
> -ConditionDirectoryNotEmpty=|/lib/dracut/hooks/cmdline
> -ConditionKernelCommandLine=|rd.break=cmdline
> -ConditionKernelCommandLine=|resume
> -ConditionKernelCommandLine=|noresume
>  
>  [Service]
>  Type=oneshot

Will be fixed by setting

Environment=DRACUT_SYSTEMD=1
Environment=NEWROOT=/sysroot

in the service files.

  parent reply	other threads:[~2013-05-28 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  5:15 [PATCH] dracut systemd cmdline service fix dyoung-H+wXaHxf7aLQT0dZR+AlfA
     [not found] ` <51946b65.1SfwJA0QAkY6Gb83%dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-28 10:53   ` Harald Hoyer [this message]
     [not found]     ` <51A48CC2.40500-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29  2:00       ` Dave Young
     [not found]         ` <51A5614C.8090606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29  8:38           ` Harald Hoyer
     [not found]             ` <51A5BE95.3070303-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-29  9:28               ` Dave Young
2013-05-30  5:07       ` Dave Young
     [not found]         ` <51A6DEA3.4060505-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30  6:52           ` Harald Hoyer
     [not found]             ` <51A6F742.5030400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-05-30  8:47               ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A48CC2.40500@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.