Re: [PATCH] arch: mips: lantiq: using strlcpy() instead of strncpy()

[John Crispin <blogic@openwrt.org>]

On 26/05/13 09:51, Chen Gang wrote:
> 'compatible' is used by strlen() in __of_device_is_compatible().
>
> So for NUL terminated string, need always be sure of ended by zero.
>
> 'of_ids' is not a structure in "include/uapi/*", so not need initialize
> all bytes, just use strlcpy() instead of strncpy().
>
>
> Signed-off-by: Chen Gang<gang.chen@asianux.com>

Acked-by: John Crispin <blogic@openwrt.org>

> ---
>   arch/mips/lantiq/prom.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
> index 9f9e875..49c4603 100644
> --- a/arch/mips/lantiq/prom.c
> +++ b/arch/mips/lantiq/prom.c
> @@ -112,7 +112,7 @@ int __init plat_of_setup(void)
>   	if (!of_have_populated_dt())
>   		panic("device tree not present");
>
> -	strncpy(of_ids[0].compatible, soc_info.compatible,
> +	strlcpy(of_ids[0].compatible, soc_info.compatible,
>   		sizeof(of_ids[0].compatible));
>   	strncpy(of_ids[1].compatible, "simple-bus",
>   		sizeof(of_ids[1].compatible));