All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: kevin@koconnor.net, seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost
Date: Tue, 28 May 2013 14:36:43 +0200	[thread overview]
Message-ID: <51A4A4DB.60403@redhat.com> (raw)
In-Reply-To: <1369744094-21727-1-git-send-email-akong@redhat.com>

Il 28/05/2013 14:28, Amos Kong ha scritto:
> Bootindex string passed from qemu:
>  /q35-pcihost@i0cf8/ethernet@2/ethernet-phy@0
> 
> We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix
> of q35 is "/q35-pcihost@i0cf8". So bootindex in qemu commandline
> doesn't work if it uses q35 machine type.
> 
> This patch fixes the pattern to match both original pc-i440fx & q35
> 
> Signed-off-by: Amos Kong <akong@redhat.com>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> ---
>  src/boot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/boot.c b/src/boot.c
> index cd9d784..f30d47e 100644
> --- a/src/boot.c
> +++ b/src/boot.c
> @@ -97,7 +97,7 @@ find_prio(const char *glob)
>      return -1;
>  }
>  
> -#define FW_PCI_DOMAIN "/pci@i0cf8"
> +#define FW_PCI_DOMAIN "/*pci*@i0cf8"
>  
>  static char *
>  build_pci_path(char *buf, int max, const char *devname, struct pci_device *pci)
> 

  reply	other threads:[~2013-05-28 12:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 12:28 [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost Amos Kong
2013-05-28 12:36 ` Paolo Bonzini [this message]
2013-05-28 22:59 ` Kevin O'Connor
2013-05-29  2:33   ` Amos Kong
2013-05-30  1:25     ` Kevin O'Connor
2013-06-02 14:29     ` [Qemu-devel] [SeaBIOS] " Gleb Natapov
2013-06-02 14:59       ` Michael S. Tsirkin
2013-06-02 15:39         ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A4A4DB.60403@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=akong@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.