From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UhKzP-0003v2-88 for mharc-grub-devel@gnu.org; Tue, 28 May 2013 10:35:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhKzE-0003u0-Ce for grub-devel@gnu.org; Tue, 28 May 2013 10:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhKz3-00058F-1s for grub-devel@gnu.org; Tue, 28 May 2013 10:34:52 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:61168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhKz2-00057q-Us for grub-devel@gnu.org; Tue, 28 May 2013 10:34:40 -0400 X-Authority-Analysis: v=2.0 cv=ZPJVaAHb c=1 sm=0 a=/DbS/tiKggfTkRRHPZEB4g==:17 a=Qsx_du5GiBkA:10 a=bfzWQn4VrGAA:10 a=kbIWSPy-SZQA:10 a=S1A5HrydsesA:10 a=IkcTkHD0fZMA:10 a=fxJcL_dCAAAA:8 a=N4gRs9jz_JEA:10 a=pGLkceISAAAA:8 a=QfKxxUxMAAAA:8 a=nsfg-B01fL_PYCgTBg8A:9 a=QEXdDO2ut3YA:10 a=MSl-tDqOz04A:10 a=/DbS/tiKggfTkRRHPZEB4g==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.78.168.186 Received: from [67.78.168.186] ([67.78.168.186:53464] helo=[10.1.1.236]) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id E8/1E-22955-F70C4A15; Tue, 28 May 2013 14:34:40 +0000 Message-ID: <51A4C07F.7000304@ubuntu.com> Date: Tue, 28 May 2013 10:34:39 -0400 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: Should LDM check be less aggressive? References: <20121121065833.7497e7e8@opensuse.site> <50FC6882.3030703@gmail.com> <20130121225030.0f98e9b8@opensuse.site> In-Reply-To: <20130121225030.0f98e9b8@opensuse.site> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 75.180.132.120 Cc: Andrey Borzenkov , =?UTF-8?B?VmxhZGltaXIgJ8+GLWNv?= =?UTF-8?B?ZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2013 14:35:02 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Did this ever get applied? On 1/21/2013 1:50 PM, Andrey Borzenkov wrote: > В Sun, 20 Jan 2013 22:58:26 +0100 Vladimir 'φ-coder/phcoder' > Serbinenko пишет: > >> On 21.11.2012 03:58, Andrey Borzenkov wrote: >> >>> + if (p->msdostype == GRUB_PC_PARTITION_TYPE_SFS) >> >> SFS is confusing as the partition in question isn't SFS, it just >> happens that LDM and SFS ids collide. Also another problem is >> that of booting in case of corrupted msdos table if LDM is intact >> but given that the kernels won't be able to recognize such a case >> anyway it's a minor one. Could you update the patch not to >> mention SFS? >> > > Done. Also updated for new hook API. > > > From: Andrey Borzenkov Subject: [PATCH] check > for LDM partition before checking LDM label > > There are several reports of leftover LDM label at the end of disk > blocking installation of grub. Check for existence of LDM > partition before checking for LDM label validity. This is the same > check as done by Linux kernel. > > Signed-off-by: Andrey Borzenkov > > --- ChangeLog | 7 +++++++ Makefile.util.def > | 2 +- grub-core/disk/ldm.c | 42 > ++++++++++++++++++++++++++++++++++++++-- > include/grub/msdos_partition.h | 1 + 4 files changed, 49 > insertions(+), 3 deletions(-) > > diff --git a/ChangeLog b/ChangeLog index 32b891a..dccdcc1 100644 > --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-01-21 > Andrey Borzenkov + + * Makefile.util.def: add > partmap/msdos.c to common library + * > include/grub/msdos_partition.h: add GRUB_PC_PARTITION_TYPE_LDM + * > grub-core/disk/ldm.c: check for existence of + > GRUB_PC_PARTITION_TYPE_LDM -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRpMB/AAoJEJrBOlT6nu75QfQH+gI7iPowpcB9UbPWHT2aOWkb 3mjdKlBkZVJbZOm2jn1kMBiNutxcVlNiuE4XT2oiaCWhWI2q6yqBbkXXHUqE+uif huSPxm/czh8mVz7FNSxmos8pJjsXFQ7tX1jI6ByoDqLjwTvnXXYfxgY6L5t/Bo1P +tFrdUBC0rAwFq99tKXkQQ802YbJ+eiLMehn0CQu2GggVsvnXGZkWb4trYr99ySw /eFQjW8mCVarbV1YH3MpLG/Jdevs0war0VmB5BrsxQ1pARiMI5aLhDENGGTJwc6X ucSJYplHdBRjSCr4ukdQNOzr3s/5wPwK9ZDaeOYkVDClnDK54fM8QBya+y6ZKAg= =rKy2 -----END PGP SIGNATURE-----