From: Ben Greear <greearb@candelatech.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: atomlin@redhat.com, netdev@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, pshelar@nicira.com, mst@redhat.com,
alexander.h.duyck@intel.com, riel@redhat.com, aquini@redhat.com,
sergei.shtylyov@cogentembedded.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets
Date: Tue, 28 May 2013 09:00:45 -0700 [thread overview]
Message-ID: <51A4D4AD.2010507@candelatech.com> (raw)
In-Reply-To: <20130527224149.GA4384@electric-eye.fr.zoreil.com>
On 05/27/2013 03:41 PM, Francois Romieu wrote:
> atomlin@redhat.com <atomlin@redhat.com> :
> [...]
>> Failed GFP_ATOMIC allocations by the network stack result in dropped
>> packets, which will be received on a subsequent retransmit, and an
>> unnecessary, noisy warning with a kernel backtrace.
>>
>> These warnings are harmless, but they still cause users to panic and
>> file bug reports over dropped packets. It would be better to hide the
>> failed allocation warnings and backtraces, and let retransmits handle
>> dropped packets quietly.
>
> Linux VM may be perfect but device drivers do stupid things.
>
> Please don't paper over it just because some shit ends in your backyard.
We should rate-limit these messages at least. When a system is low on memory
the logs can quickly fill up with useless OOM messages, further slowing
the system...
Ben
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2013-05-28 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:45 [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets atomlin
2013-05-27 18:18 ` Rafael Aquini
2013-05-27 22:41 ` Francois Romieu
2013-05-28 16:00 ` Ben Greear [this message]
2013-05-28 16:15 ` Rafael Aquini
2013-05-28 16:19 ` Ben Greear
2013-05-28 16:29 ` Eric Dumazet
2013-05-28 17:43 ` Rafael Aquini
2013-05-28 17:46 ` Eric Dumazet
2013-05-28 18:03 ` Eric Dumazet
2013-05-28 18:19 ` Joe Perches
2013-05-28 21:32 ` Rik van Riel
2013-05-28 17:29 ` Joe Perches
2013-05-28 21:30 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2013-05-26 20:19 atomlin
2013-05-27 17:39 ` Rik van Riel
2013-05-27 22:25 ` Eric Dumazet
2013-05-28 4:31 ` Joe Perches
2013-05-28 6:04 ` Eric Dumazet
2013-05-28 6:08 ` Joe Perches
2013-05-28 17:15 ` Debabrata Banerjee
2013-05-29 7:36 ` Rik van Riel
2013-05-27 17:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A4D4AD.2010507@candelatech.com \
--to=greearb@candelatech.com \
--cc=alexander.h.duyck@intel.com \
--cc=aquini@redhat.com \
--cc=atomlin@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=riel@redhat.com \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.