Re: [Qemu-devel] [PATCH 05/16] qemu-io: Don't use global bs in command implementations

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On 05/28/2013 09:37 AM, Kevin Wolf wrote:
> Am 28.05.2013 um 17:27 hat Kevin Wolf geschrieben:
>> Pass in the BlockDriverState to the command handlers instead of using
>> the global variable. This is an important step to make the commands
>> usable outside of qemu-io.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> 
>> @@ -1793,7 +1808,7 @@ static const cmdinfo_t abort_cmd = {
>>         .oneline        = "simulate a program crash using abort(3)",
>>  };
>>  
>> -static int close_f(int argc, char **argv)
>> +static int close_f(BlockDriverState *bs, int argc, char **argv)
>>  {
>>      bdrv_delete(bs);
>>      bs = NULL;
> 
> Here I missed the following hunk that I've applied locally now:
> 
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -1811,7 +1811,7 @@ static const cmdinfo_t abort_cmd = {
>  static int close_f(BlockDriverState *bs, int argc, char **argv)
>  {
>      bdrv_delete(bs);
> -    bs = NULL;
> +    qemuio_bs = NULL;

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]