From: Paolo Bonzini <pbonzini@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add a stp file for usage from build directory
Date: Tue, 28 May 2013 19:45:54 +0200 [thread overview]
Message-ID: <51A4ED52.1070907@redhat.com> (raw)
In-Reply-To: <1369763069-13689-1-git-send-email-alevy@redhat.com>
Il 28/05/2013 19:44, Alon Levy ha scritto:
> For systemtap the location of the process being tapped is crucial, as a
> result the existing stp file requires installation for use.
>
> There are now two files:
> $(TARGET_DIR)/$(QEMU_PROG).stp-installed: copied to $(tapdir)/$(QEMU_PROG).stp
> $(TARGET_DIR)/$(QEMU_PROG).stp: usable locally
The actual name of the file is $(TARGET_DIR)/$(QEMU_PROG).local.stp.
I think I prefer the one in the commit message, but anyway please respin
to make it consistent.
Paolo
> To use:
> stap -I $(TARGET_DIR) ..
>
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> Makefile.target | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index ce4391f..54687e2 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -35,7 +35,7 @@ config-target.h: config-target.h-timestamp
> config-target.h-timestamp: config-target.mak
>
> ifdef CONFIG_TRACE_SYSTEMTAP
> -stap: $(QEMU_PROG).stp
> +stap: $(QEMU_PROG).stp-installed $(QEMU_PROG).local.stp
>
> ifdef CONFIG_USER_ONLY
> TARGET_TYPE=user
> @@ -43,14 +43,24 @@ else
> TARGET_TYPE=system
> endif
>
> -$(QEMU_PROG).stp: $(SRC_PATH)/trace-events
> +$(QEMU_PROG).stp-installed: $(SRC_PATH)/trace-events
> $(call quiet-command,$(TRACETOOL) \
> --format=stap \
> --backend=$(TRACE_BACKEND) \
> --binary=$(bindir)/$(QEMU_PROG) \
> --target-arch=$(TARGET_ARCH) \
> --target-type=$(TARGET_TYPE) \
> - < $< > $@," GEN $(TARGET_DIR)$(QEMU_PROG).stp")
> + < $< > $@," GEN $(TARGET_DIR)$(QEMU_PROG).stp-installed")
> +
> +$(QEMU_PROG).local.stp: $(SRC_PATH)/trace-events
> + $(call quiet-command,$(TRACETOOL) \
> + --format=stap \
> + --backend=$(TRACE_BACKEND) \
> + --binary=$(realpath .)/$(QEMU_PROG) \
> + --target-arch=$(TARGET_ARCH) \
> + --target-type=$(TARGET_TYPE) \
> + < $< > $@," GEN $(TARGET_DIR)$(QEMU_PROG).local.stp")
> +
> else
> stap:
> endif
> @@ -186,7 +196,7 @@ endif
> endif
> ifdef CONFIG_TRACE_SYSTEMTAP
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/../systemtap/tapset"
> - $(INSTALL_DATA) $(QEMU_PROG).stp "$(DESTDIR)$(qemu_datadir)/../systemtap/tapset"
> + $(INSTALL_DATA) $(QEMU_PROG).stp-installed "$(DESTDIR)$(qemu_datadir)/../systemtap/tapset/$(QEMU_PROG).stp"
> endif
>
> GENERATED_HEADERS += config-target.h
>
prev parent reply other threads:[~2013-05-28 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:44 [Qemu-devel] [PATCH] Add a stp file for usage from build directory Alon Levy
2013-05-28 17:45 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A4ED52.1070907@redhat.com \
--to=pbonzini@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.