From: Steve Dickson <SteveD@redhat.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] clnt_vc_control: fix VERS/PROG size
Date: Tue, 28 May 2013 13:47:31 -0400 [thread overview]
Message-ID: <51A4EDB3.9070802@RedHat.com> (raw)
In-Reply-To: <6ed8842bb155fce40f3bb9283ba28e28c6432156.1368735469.git.jstancek@redhat.com>
On 16/05/13 16:25, Jan Stancek wrote:
> Following commit converted some operations to use memcpy, but the size
> of copied areas is now u_long, previously it was u_int32_t:
> commit fac3eb51c7055055bdd7dccd9db556d9e4a1cf35
> Author: Steve Dickson <steved@redhat.com>
> Date: Tue Feb 12 14:26:31 2013 -0500
> clnt_vc_control: Removed a strict-aliasing warning
>
> This broke mount on ppc64/s390x:
> # ./mount.nfs -vvv -onfsvers=3,tcp rhel6-nfs:/export/home /mnt/test
> mount.nfs: timeout set for Fri May 3 15:20:14 2013
> mount.nfs: trying text-based options 'nfsvers=3,tcp,addr=10.1.1.5'
> mount.nfs: prog 100003, trying vers=3, prot=6
> mount.nfs: portmap query failed: RPC: Program/version mismatch
> mount.nfs: Protocol not supported
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
Committed....
steved.
> ---
> src/clnt_vc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/clnt_vc.c b/src/clnt_vc.c
> index 7769809..2eab9e4 100644
> --- a/src/clnt_vc.c
> +++ b/src/clnt_vc.c
> @@ -505,7 +505,7 @@ clnt_vc_control(cl, request, info)
> sigset_t newmask;
> int rpc_lock_value;
> u_int32_t tmp;
> - u_long ltmp;
> + u_int32_t ltmp;
>
> assert(cl != NULL);
>
>
prev parent reply other threads:[~2013-05-28 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 20:25 [PATCH] clnt_vc_control: fix VERS/PROG size Jan Stancek
2013-05-28 17:47 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A4EDB3.9070802@RedHat.com \
--to=steved@redhat.com \
--cc=jstancek@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.