From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: Fix adjust_range_size_mask calling position
Date: Tue, 28 May 2013 19:14:36 -0700 [thread overview]
Message-ID: <51A5648C.3060900@zytor.com> (raw)
In-Reply-To: <CAE9FiQXrG0qZ3yJzxsOWhVtzxEY6R9g=sL7EHXZZKNj=BTjmxg@mail.gmail.com>
On 05/28/2013 04:43 PM, Yinghai Lu wrote:
>>
>> Sorry, I'm not sure I understand what the above paragraph is trying to say.
>
> We merge the continuous range with same page size allow too early.
> in the case
> [mem 0x00200000-0x3fffffff] page 2M
> [mem 0x40000000-0x7bffffff] page 2M
> after merging them, will get
> [mem 0x00200000-0x7bffffff] page 2M
> even we can use 1G page to map
> [mem 0x40000000-0x7bffffff]
>
> that will cause problem, because we map
> [mem 0x7fe00000-0x7fffffff] page 1G
> [mem 0x7c000000-0x7fdfffff] page 1G
> with 1G page.
>
> so need to adjust page size at first before merge
> [mem 0x00200000-0x3fffffff] page 2M
> [mem 0x40000000-0x7bffffff] page 2M
>
What I meant with that is please update the description so someone
uninitiated can follow the description, either now or in 5-10 years.
-hpa
next prev parent reply other threads:[~2013-05-29 2:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 4:30 [PATCH] x86, mm: fix boot hang regression Yuanhan Liu
2013-05-25 7:31 ` Yinghai Lu
2013-05-25 10:25 ` Yuanhan Liu
2013-05-28 23:27 ` Yinghai Lu
2013-05-28 23:28 ` [PATCH] x86: Fix adjust_range_size_mask calling position Yinghai Lu
2013-05-28 23:36 ` H. Peter Anvin
2013-05-28 23:43 ` Yinghai Lu
2013-05-29 2:14 ` H. Peter Anvin [this message]
2013-05-29 21:09 ` [PATCH v2] " Yinghai Lu
2013-05-31 11:32 ` Ingo Molnar
2013-05-31 11:34 ` Ingo Molnar
2013-05-31 15:53 ` [PATCH v3] " Yinghai Lu
2013-05-31 20:18 ` H. Peter Anvin
2013-05-31 20:21 ` H. Peter Anvin
2013-05-31 20:42 ` [tip:x86/urgent] " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5648C.3060900@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.