Re: Patch for thinkpad-acpi.c

[Bruce <bruce.ma@canonical.com>]

Hi, Bjorn

Thank your advice .
I will modify my code, then try to submit again.

Bruce.Ma
May 29,2013


On 05/28/2013 06:28 PM, Bjørn Mork wrote:
> Bruce <bruce.ma@canonical.com> writes:
>
>> +struct blacklist lenovo_blacklist[] = {
>> +  {
>> +    .model_s = "Lenovo LM490s",
>> +    .nummodel_s = "814YG01",
>> +  },
>
> The driver already has a list of LED support per model in the 
>
>   static const struct tpacpi_quirk led_useful_qtable[] __initconst = {}
>
> array.   Why do you duplicate this with lots of new model checking code
> instead of just using the code that's already there?
>
>>  static void led_exit(void)
>>  {
>> +        if (no_led == 1 ) {
>
> The driver already has provisions for signalling that LEDs are
> unsupported through the 'led_supported' variable.  Why do you add
> another variable, and duplicate testing in every access function?
>
> But I don't think this part is needed at all, as long as you set up the
> proper LED map in led_useful_qtable.
>
>
>
> Bjørn