From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] 50drm: Install dracut 50drm module in hostonly mode when
 drm driver is currently in use.
Date: Wed, 29 May 2013 11:44:09 +0200
Message-ID: <51A5CDE9.4090808@redhat.com>
References: <1369383763-24956-1-git-send-email-chaowang@redhat.com> <51A49E65.9000206@redhat.com> <51A56BC8.2010205@redhat.com> <20130529065726.GA28070@dhcp12-158.nay.redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <20130529065726.GA28070-UAAZkH0G2Ts1naxU1pY8ZxcY2uh10dtjAL8bYrjMMd8@public.gmane.org>
Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-ID: <initramfs.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Baoquan <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On 05/29/2013 08:57 AM, WANG Chao wrote:
> On 05/29/13 at 10:45am, Dave Young wrote:
>> On 05/28/2013 08:09 PM, Harald Hoyer wrote:
>>> On 05/24/2013 10:22 AM, WANG Chao wrote:
>>>> Now only 50plymouth module can pull in 50drm and that's very limited.
>>>> Because KMS capable drm drivers are much needed in initrd to have a
>>>> frame buffer console on the screen.
>>>>
>>>> Particularly, when building kdump initrd, plymouth module is omitted,
>>>> but drm is necessary to setup a working screen for one sitting in front
>>>> of a monitor.
>>>>
>>>> Signed-off-by: WANG Chao <chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>> ---
>>>>  modules.d/50drm/module-setup.sh | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/modules.d/50drm/module-setup.sh b/modules.d/50drm/module-setup.sh
>>>> index bf33c5b..648e8f4 100644
>>>> --- a/modules.d/50drm/module-setup.sh
>>>> +++ b/modules.d/50drm/module-setup.sh
>>>> @@ -3,6 +3,10 @@
>>>>  # ex: ts=8 sw=4 sts=4 et filetype=sh
>>>>  
>>>>  check() {
>>>> +    if [[ $hostonly ]] && [ -d /sys/module/drm/drivers ]; then
>>>> +        return 0
>>>> +    fi
>>>> +
>>>>      return 255
>>>>  }
>>>>  
>>>>
>>>
>>> Hmm, why not let the kdump module depend on drm?
>>
>> If you do not like it we can consider add it to kdump module..
> 
> So now if I build initrd w/o plymouth, I will not have frame buffer
> console in initrd. That looks more like a general issue to me.
> 
> WANG Chao

Do we really need a fb console?
If there is a valid reason, I will change "return 255" to "return 0".