From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: [PATCH] arch: alpha: kernel: using memcpy() instead of strcpy() Date: Wed, 29 May 2013 18:51:28 +0800 Message-ID: <51A5DDB0.50504@asianux.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Sender: linux-alpha-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, Thomas Gleixner , Frederic Weisbecker , josh@joshtriplett.org, srivatsa.bhat@linux.vnet.ibm.com Cc: Greg KH , linux-alpha@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-Arch When sending message in send_secondary_console_msg(), the length is not include the NUL byte, and also not copy NUL to 'ipc_buffer'. When receive message in recv_secondary_console_msg(), the 'cnt' also excludes NUL. So when get string from ipc_buffer, it may not be NUL terminated. Then use memcpy() instead of strcpy(), and set last byte NUL. Signed-off-by: Chen Gang --- arch/alpha/kernel/smp.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c index 7b60834..d3d2040 100644 --- a/arch/alpha/kernel/smp.c +++ b/arch/alpha/kernel/smp.c @@ -266,7 +266,8 @@ recv_secondary_console_msg(void) else { cp1 = (char *) &cpu->ipc_buffer[11]; cp2 = buf; - strcpy(cp2, cp1); + memcpy(cp2, cp1, cnt); + cp2[cnt] = '\0'; while ((cp2 = strchr(cp2, '\r')) != 0) { *cp2 = ' '; -- 1.7.7.6