Re: [PATCH 2/21] Add directory information to the pkgdata files

[Mark Hatle <mark.hatle@windriver.com>]

On 5/29/13 10:11 AM, Paul Eggleton wrote:
> On Wednesday 29 May 2013 10:09:44 Mark Hatle wrote:
>> Add S(ource) and B(uild) directory information to the recipe pkgdata files.
>> This allows external tools to find the appropriate information, and be able
>> to easily access the corresponding sources and build directories.
>>
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>> ---
>>   meta/classes/package.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
>> index 02a1460..19b2b4c 100644
>> --- a/meta/classes/package.bbclass
>> +++ b/meta/classes/package.bbclass
>> @@ -1124,6 +1124,8 @@ python emit_pkgdata() {
>>
>>       data_file = pkgdatadir + d.expand("/${PN}" )
>>       f = open(data_file, 'w')
>> +    f.write("S: %s\n" % d.expand("${S}"))
>> +    f.write("B: %s\n" % d.expand("${B}"))
>>       f.write("PACKAGES: %s\n" % packages)
>>       f.close()
>
> I'm not sure I'm totally comfortable with this idea. External tools shouldn't
> necessarily expect to be able to poke into the source after packaging occurs -
> rm_work (if enabled) will remove the work directory, and separately sstate may
> restore the pkgdata and not the workdir. In both situations these values will
> be invalid.
>
> If tools need to be able to find out the values of S and B then I think they
> ought to be querying them via bitbake.

When discussing this in the past, via IRC, it was mentioned that the pkgdata has 
all of the necessary data to figure out what has been built and much of the data 
that external (think eclipse based UI tools) need to figure out.

This particular case allows our tooling to not only list what was built, but 
allows the tools to go into the directory (B or S) and explore the sources, 
logs, etc.

If this is rejected, I'm fine, we'll just carry it forward on our own.. but I 
think it does have some generic value.

(Actually querying bitbake is what we started with, but when you query it 1000 
times.. it's pretty obvious this doesn't work, the time alone to query it for 
the 'B' and 'S' of each recipe is significant to the point of being unusable for 
external tools.)

--Mark

> Cheers,
> Paul
>