From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: possible_cpus broken in linux-next Date: Wed, 29 May 2013 21:02:20 +0200 Message-ID: <51A650BC.7030604@intel.com> References: <51A6367E.1060400@intel.com> <1369852557.16819.54.camel@misato.fc.hp.com> <1369853414.16819.56.camel@misato.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com ([143.182.124.37]:33391 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759396Ab3E2TCZ (ORCPT ); Wed, 29 May 2013 15:02:25 -0400 In-Reply-To: <1369853414.16819.56.camel@misato.fc.hp.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Toshi Kani , Dave Hansen Cc: Stephen Rothwell , Greg Kroah-Hartman , LKML , linux-acpi@vger.kernel.org T24gNS8yOS8yMDEzIDg6NTAgUE0sIFRvc2hpIEthbmkgd3JvdGU6Cj4gT24gV2VkLCAyMDEzLTA1 LTI5IGF0IDEyOjM1IC0wNjAwLCBUb3NoaSBLYW5pIHdyb3RlOgo+PiBPbiBXZWQsIDIwMTMtMDUt MjkgYXQgMTA6MTAgLTA3MDAsIERhdmUgSGFuc2VuIHdyb3RlOgo+ICAgOgo+Cj4+IFRoYW5rcyBm b3IgdGhlIHJlcG9ydC4gIFRoZSBmb2xsb3dpbmcgcGF0Y2ggZml4ZXMgdGhlIHByb2JsZW0uCj4+ IC1Ub3NoaQo+Pgo+PiA9PT09Cj4+IEZyb206IFRvc2hpIEthbmkgPHRvc2hpLmthbmlAaHAuY29t Pgo+PiBTdWJqZWN0OiBbUEFUQ0hdIEFDUEk6IEZpeCBzeXNmcyBjcHUvb25saW5lIG9mIG9mZmxp bmVkIGNwdXMKPiBUeXBvLiBUaGUgc3ViamVjdCBuZWVkcyB0byBiZToKPgo+IFN1YmplY3Q6IFtQ QVRDSF0gY3B1OiBGaXggc3lzZnMgY3B1L29ubGluZSBvZiBvZmZsaW5lZCBjcHVzCj4KPiAtVG9z aGkKPgo+PiBBcyByZXBvcnRlZCBieSBEYXZlIEhhbnNlbiwgc3lzZnMgY3B1L29ubGluZSBzaG93 cyAxIGZvcgo+PiBvZmZsaW5lZCBjcHVzIGF0IGJvb3QuCj4+IGh0dHBzOi8vbGttbC5vcmcvbGtt bC8yMDEzLzUvMjkvNDAzCj4+Cj4+IEZpeCB0aGlzIHByb2JsZW0gYnkgaW5pdGlhbGl6aW5nIGRl di5vZmZsaW5lIHdpdGggY3B1X29ubGluZSgpCj4+IHdoZW4gcmVnaXN0ZXJpbmcgYSBjcHUuCj4+ Cj4+IFJlcG9ydGVkLWJ5OiBEYXZlIEhhbnNlbiA8ZGF2ZS5oYW5zZW5AaW50ZWwuY29tPgo+PiBT aWduZWQtb2ZmLWJ5OiBUb3NoaSBLYW5pIDx0b3NoaS5rYW5pQGhwLmNvbT4KClRoYW5rcyBUb3No aSEKCkRhdmUsIGNhbiB5b3UgcGxlYXNlIGNvbmZpcm0gdGhhdCB0aGUgcHJvYmxlbSBpcyBmaXhl ZCBieSB0aGlzIHBhdGNoPwoKUmFmYWVsCgoKPj4gLS0tCj4+ICAgZHJpdmVycy9iYXNlL2NwdS5j IHwgMSArCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4+Cj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2Jhc2UvY3B1LmMgYi9kcml2ZXJzL2Jhc2UvY3B1LmMKPj4gaW5kZXggMTMw YmEwYi4uYjlmMGVlYyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9iYXNlL2NwdS5jCj4+ICsrKyBi L2RyaXZlcnMvYmFzZS9jcHUuYwo+PiBAQCAtMjgxLDYgKzI4MSw3IEBAIGludCBfX2NwdWluaXQg cmVnaXN0ZXJfY3B1KHN0cnVjdCBjcHUgKmNwdSwgaW50IG51bSkKPj4gICAJY3B1LT5kZXYuYnVz ID0gJmNwdV9zdWJzeXM7Cj4+ICAgCWNwdS0+ZGV2LnJlbGVhc2UgPSBjcHVfZGV2aWNlX3JlbGVh c2U7Cj4+ICAgCWNwdS0+ZGV2Lm9mZmxpbmVfZGlzYWJsZWQgPSAhY3B1LT5ob3RwbHVnZ2FibGU7 Cj4+ICsJY3B1LT5kZXYub2ZmbGluZSA9ICFjcHVfb25saW5lKG51bSk7Cj4+ICAgI2lmZGVmIENP TkZJR19BUkNIX0hBU19DUFVfQVVUT1BST0JFCj4+ICAgCWNwdS0+ZGV2LmJ1cy0+dWV2ZW50ID0g YXJjaF9jcHVfdWV2ZW50Owo+PiAgICNlbmRpZgo+CgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgVGVjaG5v bG9neSBQb2xhbmQgc3AuIHogby5vLgp6IHNpZWR6aWJhIHcgR2RhbnNrdQp1bC4gU2xvd2Fja2ll Z28gMTczCjgwLTI5OCBHZGFuc2sKClNhZCBSZWpvbm93eSBHZGFuc2sgUG9sbm9jIHcgR2RhbnNr dSwgClZJSSBXeWR6aWFsIEdvc3BvZGFyY3p5IEtyYWpvd2VnbyBSZWplc3RydSBTYWRvd2Vnbywg Cm51bWVyIEtSUyAxMDE4ODIKCk5JUCA5NTctMDctNTItMzE2CkthcGl0YWwgemFrbGFkb3d5IDIw MC4wMDAgemwKClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29u ZmlkZW50aWFsIG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lw aWVudChzKS4gQW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5 IHByb2hpYml0ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFz ZSBjb250YWN0IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966066Ab3E2TCa (ORCPT ); Wed, 29 May 2013 15:02:30 -0400 Received: from mga14.intel.com ([143.182.124.37]:33391 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759396Ab3E2TCZ (ORCPT ); Wed, 29 May 2013 15:02:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,765,1363158000"; d="scan'208";a="248307559" Message-ID: <51A650BC.7030604@intel.com> Date: Wed, 29 May 2013 21:02:20 +0200 From: "Rafael J. Wysocki" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Toshi Kani , Dave Hansen CC: Stephen Rothwell , Greg Kroah-Hartman , LKML , linux-acpi@vger.kernel.org Subject: Re: possible_cpus broken in linux-next References: <51A6367E.1060400@intel.com> <1369852557.16819.54.camel@misato.fc.hp.com> <1369853414.16819.56.camel@misato.fc.hp.com> In-Reply-To: <1369853414.16819.56.camel@misato.fc.hp.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4TJ2XXR012197 On 5/29/2013 8:50 PM, Toshi Kani wrote: > On Wed, 2013-05-29 at 12:35 -0600, Toshi Kani wrote: >> On Wed, 2013-05-29 at 10:10 -0700, Dave Hansen wrote: > : > >> Thanks for the report. The following patch fixes the problem. >> -Toshi >> >> ==== >> From: Toshi Kani >> Subject: [PATCH] ACPI: Fix sysfs cpu/online of offlined cpus > Typo. The subject needs to be: > > Subject: [PATCH] cpu: Fix sysfs cpu/online of offlined cpus > > -Toshi > >> As reported by Dave Hansen, sysfs cpu/online shows 1 for >> offlined cpus at boot. >> https://lkml.org/lkml/2013/5/29/403 >> >> Fix this problem by initializing dev.offline with cpu_online() >> when registering a cpu. >> >> Reported-by: Dave Hansen >> Signed-off-by: Toshi Kani Thanks Toshi! Dave, can you please confirm that the problem is fixed by this patch? Rafael >> --- >> drivers/base/cpu.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c >> index 130ba0b..b9f0eec 100644 >> --- a/drivers/base/cpu.c >> +++ b/drivers/base/cpu.c >> @@ -281,6 +281,7 @@ int __cpuinit register_cpu(struct cpu *cpu, int num) >> cpu->dev.bus = &cpu_subsys; >> cpu->dev.release = cpu_device_release; >> cpu->dev.offline_disabled = !cpu->hotpluggable; >> + cpu->dev.offline = !cpu_online(num); >> #ifdef CONFIG_ARCH_HAS_CPU_AUTOPROBE >> cpu->dev.bus->uevent = arch_cpu_uevent; >> #endif > --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I