From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1UhzfN-0004Bd-6N
	for qemu-devel@nongnu.org; Thu, 30 May 2013 06:01:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1UhzfG-0007Yw-Ja
	for qemu-devel@nongnu.org; Thu, 30 May 2013 06:01:05 -0400
Received: from katherinewilliamsonsoprano.co.uk ([82.165.34.74]:52633
	helo=p15195424.pureserver.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1UhzfG-0007Yc-DU
	for qemu-devel@nongnu.org; Thu, 30 May 2013 06:00:58 -0400
Received: from [86.188.254.49] (helo=[172.30.1.77])
	by p15195424.pureserver.info with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.43) id 1UhzfA-0004vH-8b
	for qemu-devel@nongnu.org; Thu, 30 May 2013 11:00:56 +0100
Message-ID: <51A72348.7040306@ilande.co.uk>
Date: Thu, 30 May 2013 11:00:40 +0100
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Unable to parse -device drivers containing commas?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

Hi all,

I found that the QEMU -device command line parser doesn't seem to like 
driver names containing a comma such as "SUNW,tcx" for the video driver 
on qemu-system-sparc:

$ ./qemu-system-sparc -device SUNW,tcx,help
qemu-system-sparc: -device SUNW,tcx,help: Parameter 'driver' expects 
device type
$ ./qemu-system-sparc -device 'SUNW,tcx',help
qemu-system-sparc: -device SUNW,tcx,help: Parameter 'driver' expects 
device type
$ ./qemu-system-sparc -device "SUNW,tcx",help
qemu-system-sparc: -device SUNW,tcx,help: Parameter 'driver' expects 
device type

If I try temporarily removing the comma from the TypeInfo name field in 
hw/display/tcx.c then all is fine:

$ ./qemu-system-sparc -device 'SUNWtcx',help
SUNWtcx.vram_size=hex32
SUNWtcx.width=uint16
SUNWtcx.height=uint16
SUNWtcx.depth=uint16
$ ./qemu-system-sparc -device SUNWtcx,help
SUNWtcx.vram_size=hex32
SUNWtcx.width=uint16
SUNWtcx.height=uint16
SUNWtcx.depth=uint16

Note that there are a couple of other devices in the SPARC32 device tree 
with this problem, since the general device naming convention on SPARC 
is in the form <manufacturer>,<device>. Is there a way of escaping the 
commas on the command line so that it is possible to list properties for 
drivers named in this way?


Many thanks,

Mark.