From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Egger, Christoph" <chegger@amazon.de>
Subject: Re: [PATCH] build: disable building kernel subsystem by
	default.
Date: Thu, 30 May 2013 12:32:22 +0200
Message-ID: <51A72AB6.5000807@amazon.de>
References: <1368628571.11138.43.camel@hastur.hellion.org.uk>
	<1369904954-13283-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1369904954-13283-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 30.05.13 11:09, Ian Campbell wrote:
> This support is obsolete and harks back to the days of out of tree Linux
> kernel trees.
> 
> I think this could really be deleted entirely but for 4.3 lets just disable.
> The list of kernels to build is empty by default anyway.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Christoph Egger <chegger@amazon.de>
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: Christoph Egger <chegger@amazon.de>

> ---
> As well as George's release Ack this needs confirmation from Ian J that it
> isn't going to confuse the test system.
> ---
>  Makefile     |    2 +-
>  configure    |    5 ++---
>  configure.ac |    2 +-
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 5a7107e..e47f29c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@
>  all: dist
>  
>  -include config/Toplevel.mk
> -SUBSYSTEMS?=xen kernels tools stubdom docs
> +SUBSYSTEMS?=xen tools stubdom docs
>  TARGS_DIST=$(patsubst %, dist-%, $(SUBSYSTEMS))
>  TARGS_INSTALL=$(patsubst %, install-%, $(SUBSYSTEMS))
>  
> diff --git a/configure b/configure
> index d15b539..07cac69 100755
> --- a/configure
> +++ b/configure
> @@ -1245,7 +1245,7 @@ Optional Features:
>    --disable-FEATURE       do not include FEATURE (same as --enable-FEATURE=no)
>    --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
>    --disable-xen           Disable build and install of xen
> -  --disable-kernels       Disable build and install of kernels
> +  --enable-kernels        Enable build and install of kernels
>    --disable-tools         Disable build and install of tools
>    --enable-stubdom        Enable build and install of stubdom
>    --disable-docs          Disable build and install of docs
> @@ -1892,8 +1892,7 @@ fi
>  else
>  
>  
> -kernels=y
> -SUBSYSTEMS="$SUBSYSTEMS kernels"
> +kernels=n
>  
>  
>  fi
> diff --git a/configure.ac b/configure.ac
> index ce06dad..1164fbf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -23,7 +23,7 @@ case "$host_cpu" in
>  esac
>  
>  AX_SUBSYSTEM_DEFAULT_ENABLE([xen])
> -AX_SUBSYSTEM_DEFAULT_ENABLE([kernels])
> +AX_SUBSYSTEM_DEFAULT_DISABLE([kernels])
>  AX_SUBSYSTEM_DEFAULT_ENABLE([tools])
>  AX_SUBSYSTEM_CONDITIONAL([stubdom], $arch_enable_stubdom)
>  AX_SUBSYSTEM_DEFAULT_ENABLE([docs])
>