From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Egger, Christoph" <chegger@amazon.de>
Subject: Re: tools/misc/xencov.c: build failure on NetBSD
Date: Thu, 30 May 2013 14:43:26 +0200
Message-ID: <51A7496E.2060600@amazon.de>
References: <51923657.6080307@amazon.de>
	<loom.20130523T014318-361@post.gmane.org>
	<1369300418.17830.17.camel@zakaz.uk.xensource.com>
	<CADGo8CVrOCO8is4Rx-+qPTV9AfpY2PZKNR8iyBq0quCb3M9i0w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CADGo8CVrOCO8is4Rx-+qPTV9AfpY2PZKNR8iyBq0quCb3M9i0w@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Miguel Clara <miguelmclara@gmail.com>
Cc: xen-devel@lists.xensource.com, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 23.05.13 12:59, Miguel Clara wrote:
> For now I simply added the code to tools/misc/xencov.c
> 
> Not sure if its the best way to do it.
> 
> On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:
>>> Christoph Egger <chegger <at> amazon.de> writes:
>>>
>>>>
>>>> Hi,
>>>>
>>>> tools/misc/xencov.c fails to build.
>>>> NetBSD does not have MAP_LOCKED.
>>>>
>>>> Christoph
>>>>
>>>
>>> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
>>> this happened before in other parts of the code...
>>> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html
>>>
>>> I guess this would fix it...
>>
>> Please can you confirm and if so submit a patch
>>
>> See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on
>> how to do that.
>>
>>>
>>> #ifdef __NetBSD__
>>> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */
>>> #define MAP_LOCKED MAP_WIRED
>>> #endif
>>>
>>> Sadly I came across another error, still searching if it was already posted,
>>> otherwise I will!

I send this as a proper patch. Please add your Signed-off-by.

Christoph