From: "Andreas Färber" <afaerber@suse.de>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qiaonuohan@cn.fujitsu.com, qemu-devel <qemu-devel@nongnu.org>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses
Date: Thu, 30 May 2013 16:29:47 +0200 [thread overview]
Message-ID: <51A7625B.60800@suse.de> (raw)
In-Reply-To: <20130528141922.135a6dd0@redhat.com>
Am 28.05.2013 20:19, schrieb Luiz Capitulino:
> The code used to walk IA-32e page-tables, and possibly PAE page-tables,
> uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address.
>
> However, as we use a uint64_t to store the resulting address, that mask
> gets expanded to 0xfffffffffffff000 which not only ends up selecting
> reserved bits but also selects the XD bit (execute-disable) which
> happens to be enabled by Windows 8, causing qemu_get_ram_ptr() to abort.
>
> This commit fixes that problem by replacing ~0xfff by a correct mask
> that only selects the address bit range (ie. bits 51:12).
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
But please add a target-i386: prefix when queuing it.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-05-30 14:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:19 [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses Luiz Capitulino
2013-05-30 12:59 ` Luiz Capitulino
2013-05-30 13:16 ` Laszlo Ersek
2013-05-30 13:16 ` Luiz Capitulino
2013-05-30 14:10 ` Andreas Färber
2013-05-30 14:14 ` Luiz Capitulino
2013-05-30 14:22 ` Andreas Färber
2013-05-30 14:25 ` Luiz Capitulino
2013-05-30 14:29 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A7625B.60800@suse.de \
--to=afaerber@suse.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.