From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-we0-f169.google.com ([74.125.82.169]:42078 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530Ab3E3OeG (ORCPT ); Thu, 30 May 2013 10:34:06 -0400 Received: by mail-we0-f169.google.com with SMTP id q55so315001wes.14 for ; Thu, 30 May 2013 07:34:04 -0700 (PDT) Message-ID: <51A7635A.8070300@monstr.eu> Date: Thu, 30 May 2013 16:34:02 +0200 From: Michal Simek Reply-To: monstr@monstr.eu MIME-Version: 1.0 To: Guenter Roeck CC: Michal Simek , linux-kernel@vger.kernel.org, Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH 3/3] watchdog: xilinx: Add WDIOC_SETTIMEOUT ioctl function References: <595eb49b34909318959fe6825c209a7d635ed849.1369916757.git.michal.simek@xilinx.com> <20130530140754.GB28232@roeck-us.net> <51A75F11.7000001@monstr.eu> <20130530142145.GA28856@roeck-us.net> In-Reply-To: <20130530142145.GA28856@roeck-us.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2AOUUNBEDMDHPIJSSAOLI" Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AOUUNBEDMDHPIJSSAOLI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/30/2013 04:21 PM, Guenter Roeck wrote: > On Thu, May 30, 2013 at 04:15:45PM +0200, Michal Simek wrote: >> On 05/30/2013 04:07 PM, Guenter Roeck wrote: >>> On Thu, May 30, 2013 at 02:26:04PM +0200, Michal Simek wrote: >>>> Standard watchdog programs try to setup timeout >>>> via ioctl and this functionality should be implemented. >>>> Timeout value is hardcoded in the hardware but >>>> based on Documentation/watchdog/watchdog-api.txt >>>> can return the real timeout used in the same variable. >>>> >>>> Signed-off-by: Michal Simek >>>> --- >>>> drivers/watchdog/of_xilinx_wdt.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_= xilinx_wdt.c >>>> index 79f358c..a3bbe72 100644 >>>> --- a/drivers/watchdog/of_xilinx_wdt.c >>>> +++ b/drivers/watchdog/of_xilinx_wdt.c >>>> @@ -253,6 +253,7 @@ static long xwdt_ioctl(struct file *file, unsign= ed int cmd, unsigned long arg) >>>> xwdt_keepalive(); >>>> return 0; >>>> >>>> + case WDIOC_SETTIMEOUT: >>>> case WDIOC_GETTIMEOUT: >>>> if (no_timeout) >>>> return -ENOTTY; >>> >>> Watchdog programs should check ident.options before trying to set the= timeout. >>> If they don't, there is an application bug. I don't think it is a goo= d idea >>> to start hacking the kernel to work around application bugs. >> >> Based on Documentation/watchdog/watchdog-api.txt >> >> "For some drivers it is possible to modify the watchdog timeout on the= >> fly with the SETTIMEOUT ioctl, those drivers have the WDIOF_SETTIMEOUT= >> flag set in their option field. The argument is an integer >=20 > Yes, but WDIOF_SETTIMEOUT is not set in the driver's option field. ok. It means I should probably enable it. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform ------enig2AOUUNBEDMDHPIJSSAOLI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGnY1oACgkQykllyylKDCFW3QCffVpRuUwomAWO6c9FgddrQYQ3 tbsAoIyIMTIEIO5OmnFCJ/ADwZPdHWcw =T1bT -----END PGP SIGNATURE----- ------enig2AOUUNBEDMDHPIJSSAOLI--