From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
To: "Roland Dreier" <roland@kernel.org>
Cc: "Michael Chan" <mchan@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: BQL-related tg3 transmit timeout on 5720 / Dell R720
Date: Thu, 30 May 2013 07:34:50 -0700 [thread overview]
Message-ID: <51A7638A.5030108@broadcom.com> (raw)
In-Reply-To: <CAL1RGDW=SC3E9VvQXki0Gajj0xBqwHjBWM95k00J6zn1tF1mgg@mail.gmail.com>
On 5/30/2013 2:05 AM, Roland Dreier wrote:
> On Wed, May 22, 2013 at 3:02 PM, Roland Dreier <roland@kernel.org> wrote:
>> I'll try to find a kernel where tg3 works on this system so I can bisect.
>
> So I finally was able to successfully bisect our problem with tg3
> transmit timeouts with recent kernels. Recall this was on on _some_
> of our Dell R720 systems with 4X tg3 ethernet with devices like:
>
> tg3 0000:02:00.0: eth0: Tigon3 [partno(BCM95720) rev 5720000] (PCI
> Express) MAC address 90:b1:1c:3f:46:b8
> tg3 0000:02:00.0: eth0: attached PHY is 5720C (10/100/1000Base-T
> Ethernet) (WireSpeed[1], EEE[1])
>
> The bisection came down to
>
> commit 298376d3e8f00147548c426959ce79efc47b669a
> Author: Tom Herbert <therbert@google.com>
> Date: Mon Nov 28 08:33:30 2011
>
> tg3: Support for byte queue limits
>
> Changes to tg3 to use byte queue limits.
>
[...]
> and each send completes in turn.
>
> For now I can work around the issue by hacking BQL out of tg3 in our
> kernel, but I guess it would be good to understand this tg3-specific
> issue of sends not completing and handle that in the tg3 driver.
>
Thanks for the bisect and detailed analysis. I will investigate this
further.
> I have a system that reproduces this very reliably, so let me know if
> there is any further logging or other info that would help understand
> this further.
>
Is the 5720 a NIC or a LOM? If it's a NIC would it be possible to try it
on a different system to see if the behaviour depends on the system at all?
> Thanks,
> Roland
>
next prev parent reply other threads:[~2013-05-30 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 9:05 BQL-related tg3 transmit timeout on 5720 / Dell R720 Roland Dreier
2013-05-30 14:34 ` Nithin Nayak Sujir [this message]
2013-05-30 16:19 ` Roland Dreier
2013-05-31 0:51 ` Nithin Nayak Sujir
2013-06-03 16:40 ` Roland Dreier
2013-06-03 16:59 ` Nithin Nayak Sujir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A7638A.5030108@broadcom.com \
--to=nsujir@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.