From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Timur Tabi <timur.tabi@calxeda.com>
Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>,
tj@kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller
Date: Thu, 30 May 2013 18:38:35 +0400 [thread overview]
Message-ID: <51A7646B.6080203@cogentembedded.com> (raw)
In-Reply-To: <51A76197.9080708@calxeda.com>
Hello.
On 30-05-2013 18:26, Timur Tabi wrote:
>> - const unsigned long *timing = sata_ehc_deb_timing(&link->eh_context);
>> + const unsigned long timing[] = { 5, 100, 500};
> You'll save space and time if you also make this array "static",
> otherwise the compiler will build the array every time this function is
> called.
No, *const* specifier is enough to not build this array every time.
It will be put into the .const section.
WBR, Sergei
next prev parent reply other threads:[~2013-05-30 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 14:18 [PATCH v2] ata: increase retry count but shorten duration for Calxeda controller Mark Langsdorf
2013-05-30 14:26 ` Timur Tabi
2013-05-30 14:38 ` Sergei Shtylyov [this message]
2013-05-30 14:39 ` Timur Tabi
2013-05-31 6:53 ` Clemens Ladisch
2013-05-31 7:40 ` Tejun Heo
2013-05-31 13:13 ` Sergei Shtylyov
2013-05-31 1:20 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A7646B.6080203@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
--cc=timur.tabi@calxeda.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.