From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui4nR-0001L5-40 for qemu-devel@nongnu.org; Thu, 30 May 2013 11:29:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui4nL-0004Hz-OW for qemu-devel@nongnu.org; Thu, 30 May 2013 11:29:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44765 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui4nL-0004Hv-In for qemu-devel@nongnu.org; Thu, 30 May 2013 11:29:39 -0400 Message-ID: <51A77062.8050503@suse.de> Date: Thu, 30 May 2013 17:29:38 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1369906048-22212-1-git-send-email-mst@redhat.com> <1369906048-22212-3-git-send-email-mst@redhat.com> In-Reply-To: <1369906048-22212-3-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Blue Swirl , qemu-devel@nongnu.org Am 30.05.2013 11:30, schrieb Michael S. Tsirkin: > firmware_abi.h with structs for OpenBIOS landed in hw/sparc/ by mistake > - move it to hw/nvram/ alongside fw_cfg.h. In addition to sparc it's > included from ppc mac_nvram.c and will need to include it from prep.c i= n > the future. >=20 > Cc: Andreas F=E4rber > Signed-off-by: Michael S. Tsirkin > --- > hw/sparc/sun4m.c | 2 +- > hw/sparc64/sun4u.c | 2 +- > include/hw/nvram/openbios_firmware_abi.h | 73 ++++++++++++++++++++++++= ++++++++ > include/hw/sparc/firmware_abi.h | 73 ------------------------= -------- > 4 files changed, 75 insertions(+), 75 deletions(-) > create mode 100644 include/hw/nvram/openbios_firmware_abi.h > delete mode 100644 include/hw/sparc/firmware_abi.h Thanks for picking my suggestion up! Same applies as for other patch: In general Acked-by: Andreas F=E4rber Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg