From: Laszlo Ersek <lersek@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object
Date: Thu, 30 May 2013 18:06:09 +0200 [thread overview]
Message-ID: <51A778F1.7070304@redhat.com> (raw)
In-Reply-To: <1369920427-18274-3-git-send-email-mst@redhat.com>
On 05/30/13 15:28, Michael S. Tsirkin wrote:
> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
> index 1483f27..910e44f 100644
> --- a/hw/misc/pvpanic.c
> +++ b/hw/misc/pvpanic.c
> @@ -96,7 +96,7 @@ static int pvpanic_isa_initfn(ISADevice *dev)
> isa_register_ioport(dev, &s->io, s->ioport);
>
> if (!port_configured) {
> - fw_cfg = object_resolve_path("/machine/fw_cfg", NULL);
> + fw_cfg = fw_cfg_find();
> if (fw_cfg) {
> fw_cfg_add_file(fw_cfg, "etc/pvpanic-port",
> g_memdup(&s->ioport, sizeof(s->ioport)),
Explains 1/3 too, OK.
Laszlo
next prev parent reply other threads:[~2013-05-30 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 13:27 [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Michael S. Tsirkin
2013-05-30 13:27 ` [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly Michael S. Tsirkin
2013-05-30 15:05 ` Laszlo Ersek
2013-05-30 15:41 ` Paolo Bonzini
2013-05-30 15:56 ` Laszlo Ersek
2013-05-30 16:03 ` Laszlo Ersek
2013-05-30 16:01 ` Paolo Bonzini
2013-05-30 17:36 ` Michael S. Tsirkin
2013-05-30 13:28 ` [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object Michael S. Tsirkin
2013-05-30 16:06 ` Laszlo Ersek [this message]
2013-05-31 1:47 ` Hu Tao
2013-05-30 13:28 ` [Qemu-devel] [PATCH 3/3] fw_cfg: fw_cfg is a singleton Michael S. Tsirkin
2013-05-30 16:06 ` [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Laszlo Ersek
2013-05-31 1:51 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A778F1.7070304@redhat.com \
--to=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.