From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:52792 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756274Ab3E3SEZ (ORCPT ); Thu, 30 May 2013 14:04:25 -0400 Message-ID: <51A794A4.1010502@wwwdotorg.org> Date: Thu, 30 May 2013 12:04:20 -0600 From: Stephen Warren MIME-Version: 1.0 To: Jay Agarwal CC: "'thierry.reding@avionic-design.de'" , "'linux@arm.linux.org.uk'" , "'bhelgaas@google.com'" , "'olof@lixom.net'" , "'mturquette@linaro.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'linux-tegra@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" , "'linux-pci@vger.kernel.org'" Subject: Re: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu References: <1368010660-31465-1-git-send-email-jagarwal@nvidia.com> <1368010660-31465-4-git-send-email-jagarwal@nvidia.com> <518A8596.7070702@wwwdotorg.org> <51A62042.7070304@wwwdotorg.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/30/2013 11:37 AM, Jay Agarwal wrote: ... > I have taken care of all your comments, but Ethernet device is not working for me neither on cardhu nor harmony. > Could be related to my process or board, Currently debugging this. Are you talking about a PCIe-based Ethernet device on Harmony, or the one that's built into the board? The on-board Ethernet device is USB, and should work fine already, and irrespective of any PCIe patches. I have only tried an XHCI USB controller in the PCIe slot on Harmony, so I can't say if Ethernet not working is a regression or not. Does the Ethernet device work with just Thierry's patches and not yours? > Parallely, should I push my patches for review so that it is clear from other aspects? Well, if the patches don't work, I suppose there's not much use posting them since they'll just need changes before they can be usefully applied anyway. IIRC, most of my comments last time were fairly minor, so there isn't much need for a separate review of them, right? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu Date: Thu, 30 May 2013 12:04:20 -0600 Message-ID: <51A794A4.1010502@wwwdotorg.org> References: <1368010660-31465-1-git-send-email-jagarwal@nvidia.com> <1368010660-31465-4-git-send-email-jagarwal@nvidia.com> <518A8596.7070702@wwwdotorg.org> <51A62042.7070304@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jay Agarwal Cc: "'thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org'" , "'linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org'" , "'bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org'" , "'olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org'" , "'mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org'" , "'linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org'" , "'linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'" , "'linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'" , "'linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'" List-Id: linux-tegra@vger.kernel.org On 05/30/2013 11:37 AM, Jay Agarwal wrote: ... > I have taken care of all your comments, but Ethernet device is not working for me neither on cardhu nor harmony. > Could be related to my process or board, Currently debugging this. Are you talking about a PCIe-based Ethernet device on Harmony, or the one that's built into the board? The on-board Ethernet device is USB, and should work fine already, and irrespective of any PCIe patches. I have only tried an XHCI USB controller in the PCIe slot on Harmony, so I can't say if Ethernet not working is a regression or not. Does the Ethernet device work with just Thierry's patches and not yours? > Parallely, should I push my patches for review so that it is clear from other aspects? Well, if the patches don't work, I suppose there's not much use posting them since they'll just need changes before they can be usefully applied anyway. IIRC, most of my comments last time were fairly minor, so there isn't much need for a separate review of them, right? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 30 May 2013 12:04:20 -0600 Subject: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu In-Reply-To: References: <1368010660-31465-1-git-send-email-jagarwal@nvidia.com> <1368010660-31465-4-git-send-email-jagarwal@nvidia.com> <518A8596.7070702@wwwdotorg.org> <51A62042.7070304@wwwdotorg.org> Message-ID: <51A794A4.1010502@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/30/2013 11:37 AM, Jay Agarwal wrote: ... > I have taken care of all your comments, but Ethernet device is not working for me neither on cardhu nor harmony. > Could be related to my process or board, Currently debugging this. Are you talking about a PCIe-based Ethernet device on Harmony, or the one that's built into the board? The on-board Ethernet device is USB, and should work fine already, and irrespective of any PCIe patches. I have only tried an XHCI USB controller in the PCIe slot on Harmony, so I can't say if Ethernet not working is a regression or not. Does the Ethernet device work with just Thierry's patches and not yours? > Parallely, should I push my patches for review so that it is clear from other aspects? Well, if the patches don't work, I suppose there's not much use posting them since they'll just need changes before they can be usefully applied anyway. IIRC, most of my comments last time were fairly minor, so there isn't much need for a separate review of them, right?