From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiAJg-0004rD-3R for qemu-devel@nongnu.org; Thu, 30 May 2013 17:23:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiAJb-0000LX-6I for qemu-devel@nongnu.org; Thu, 30 May 2013 17:23:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiAJa-0000LT-VV for qemu-devel@nongnu.org; Thu, 30 May 2013 17:23:19 -0400 Message-ID: <51A7C32E.5090208@redhat.com> Date: Thu, 30 May 2013 15:22:54 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369907728-4175-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1369907728-4175-2-git-send-email-wdongxu@linux.vnet.ibm.com> In-Reply-To: <1369907728-4175-2-git-send-email-wdongxu@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JILJQJBVVTDTFNSXIIXQ" Subject: Re: [Qemu-devel] [PATCH V15 1/6] add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dongxu Wang Cc: qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JILJQJBVVTDTFNSXIIXQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/30/2013 03:55 AM, Dongxu Wang wrote: > From: Dong Xu Wang >=20 > qemu_opts_print has no user now, so can re-write the function safely. >=20 > qemu_opts_print will be used while using "qemu-img create", it will > produce the same output as previous code. >=20 > The behavior of this function has changed: >=20 > 1. Print every possible option, whether a value has been set or not. > 2. Option descriptors may provide a default value. > 3. Print to stdout instead of stderr. >=20 > Previously the behavior was to print every option that has been set. > Options that have not been set would be skipped. Up to here is fine. >=20 > v13->v14: > 1) fix memory leak. > 2) make opt_set do not accpet null value argument. >=20 > v12->v13 > 1) re-write commit message. >=20 > v11->v12 > 1) make def_value_str become the real default value string in opt_set > function. >=20 > v10->v11: > 1) print all values that have actually been assigned while accept-any > cases. >=20 > v7->v8: > 1) print "elements =3D> accept any params" while opts_accepts_any() =3D= =3D > true. > 2) since def_print_str is the default value if an option isn't set, > so rename it to def_value_str. However, this chunk should be moved to appear after the '---' separator; it's useful during review, but does not need to be part of qemu.git. >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Dongxu Wang And this looks fishy, having two S-o-B with slightly different spellings of your name. Pick one and stick with it. > --- Here is where patch changelogs go. For more hints, see http://wiki.qemu.org/Contribute/SubmitAPatch > include/qemu/option.h | 3 ++- > util/qemu-option.c | 32 ++++++++++++++++++++++++++------ > 2 files changed, 28 insertions(+), 7 deletions(-) >=20 > diff --git a/include/qemu/option.h b/include/qemu/option.h > index bdb6d21..b928ab0 100644 > --- a/include/qemu/option.h > +++ b/include/qemu/option.h > @@ -96,6 +96,7 @@ typedef struct QemuOptDesc { > const char *name; > enum QemuOptType type; > const char *help; > + const char *def_value_str; > } QemuOptDesc; Now that we have the 'query-command-line-options' QMP command, I think it's worth expanding that command to expose the default value of an option, when one is given. It's probably content for a separate patch (util/qemu-config.c:query_option_descs() and qapi-schema.json), but still belongs as part of this series. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JILJQJBVVTDTFNSXIIXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRp8MuAAoJEKeha0olJ0NqIzgH/i8vFIWTpc7eA6tUfFHie2gb GfIFBn6XE2SjdlFfMQs6Al5vMM3vJFQPINQ2WNkkCO8uGOfrDa++QoXfsjfD/Mbr GNPm32u7fy0xeJVbfW+E18hmbmHb6jejpMqjaHb/W4HlhwNk5o80FC1s/335jXGH r8PP+qkNkDkDPq9u17MgFFHZRLlZ82Ccs6WtzKEc6s/ibW4LYVfXpk5dOA4K17lz flr8mBjz6cbAiXvFjqWFSNSRkIQDOniGCiIXtlZya+DzLMxYxMop/RnquUoYBCNB rdo5tTEWfYEBlub9e5RB+uowlaNduL7RQNO/xHCS/weXbSP9k6lmGRlUkM8emr4= =M8Fo -----END PGP SIGNATURE----- ------enig2JILJQJBVVTDTFNSXIIXQ--