All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: linux-media@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	hj210.choi@samsung.com, sw0312.kim@samsung.com
Subject: Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization
Date: Fri, 31 May 2013 04:10:57 +0300	[thread overview]
Message-ID: <51A7F8A1.7020709@iki.fi> (raw)
In-Reply-To: <519A3219.9040809@samsung.com>

Hi Andrzej,

Andrzej Hajda wrote:
>> I have to say I don't think it's neither meaningful to acquire that mutex in
>> v4l2_ctrl_handler_free(), though, since the whole going to be freed next
>> anyway: reference counting would be needed to prevent bad things from
>> happening, in case the drivers wouldn't take care of that.
> I do not understand what do you mean exactly. Could you please explain
> it more?
> What do you want to reference count?

I don't want to, but simply acquiring a lock which is a part of an 
object being destroyed makes no sense. If something else has a reference 
to the object you're screwed anyway; acquiring the lock does not help.

-- 
Sakari Ailus
sakari.ailus@iki.fi

  reply	other threads:[~2013-05-31  1:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  8:14 [PATCH RFC v3 0/3] added managed media/v4l2 initialization Andrzej Hajda
2013-05-16  8:14 ` [PATCH RFC v3 1/3] media: added managed media entity initialization Andrzej Hajda
2013-06-18 22:03   ` Laurent Pinchart
2013-06-19 10:33     ` Andrzej Hajda
2013-06-19 10:36       ` Laurent Pinchart
2013-06-20  6:11         ` Andrzej Hajda
2013-05-16  8:14 ` [PATCH RFC v3 2/3] media: added managed v4l2 control initialization Andrzej Hajda
2013-05-16 22:34   ` Sakari Ailus
2013-05-20 14:24     ` Andrzej Hajda
2013-05-31  1:10       ` Sakari Ailus [this message]
2013-05-23 10:39     ` Hans Verkuil
2013-05-31  1:08       ` Sakari Ailus
2013-05-31  7:59         ` Hans Verkuil
2013-06-06 21:41           ` Sakari Ailus
2013-06-09 18:05             ` Sylwester Nawrocki
2013-06-10 13:36               ` Hans Verkuil
2013-05-23 10:40   ` Hans Verkuil
2013-06-18 22:04   ` Laurent Pinchart
2013-05-16  8:14 ` [PATCH RFC v3 3/3] media: added managed v4l2/i2c subdevice initialization Andrzej Hajda
2013-05-23 10:40   ` Hans Verkuil
2013-06-18 22:00   ` Laurent Pinchart
2013-06-19 14:10     ` [PATCH RFC v4] " Andrzej Hajda
2013-08-22 11:10       ` Hans Verkuil
2013-08-22 11:20         ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A7F8A1.7020709@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=a.hajda@samsung.com \
    --cc=hj210.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.