From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: Xen 4.3 development update -- RC3 willo be an actual candidate, please test Date: Fri, 31 May 2013 11:42:33 +0100 Message-ID: <51A87E99.9040707@citrix.com> References: <51A78EBB020000780009B712@nat28.tlf.novell.com> <51A78D78.7080209@citrix.com> <51A85BA702000078000D9DFA@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51A85BA702000078000D9DFA@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , "Keir (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 31/05/13 07:13, Jan Beulich wrote: >>>> On 30.05.13 at 19:33, Andrew Cooper wrote: >> FWIW, >> >> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=2ae8b9173fb2388af651 >> 4c730d620ed5f450bc34 >> >> was also debugging and should probably come back out. I am not certain >> that it actually caught any issues, but we did the fixing up of legacy >> PIC interrupts which I suspect might have been the cause of this. > Indeed, though I would just frame the block by #ifndef NDEBUG. > Keir - do you have any preference here? > > Jan > Having used similar debugging structures for this recent XSA-36 related issue, the result from this change is not actually too useful. I would certainly suggest complete removal over having in in an NDEBUG section. ~Andrew