From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiOky-0002Bf-Jx for qemu-devel@nongnu.org; Fri, 31 May 2013 08:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiOkx-0005oQ-HK for qemu-devel@nongnu.org; Fri, 31 May 2013 08:48:32 -0400 Received: from mail-vb0-x231.google.com ([2607:f8b0:400c:c02::231]:47138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiOkx-0005oM-Co for qemu-devel@nongnu.org; Fri, 31 May 2013 08:48:31 -0400 Received: by mail-vb0-f49.google.com with SMTP id q13so996792vbe.36 for ; Fri, 31 May 2013 05:48:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51A89C11.8040108@redhat.com> Date: Fri, 31 May 2013 14:48:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369816047-16384-1-git-send-email-jordan.l.justen@intel.com> <1369816047-16384-2-git-send-email-jordan.l.justen@intel.com> <20130531020612.GA18156@morn.localdomain> In-Reply-To: <20130531020612.GA18156@morn.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Jordan Justen , qemu-devel@nongnu.org Il 31/05/2013 04:06, Kevin O'Connor ha scritto: > On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: >> > The isapc machine with seabios currently requires the BIOS region >> > to be read/write memory rather than read-only memory. >> > >> > KVM currently cannot support the BIOS as a ROM region, but qemu >> > in non-KVM mode can. Based on this, isapc machine currently only >> > works with KVM. >> > >> > To work-around this isapc issue, this change avoids marking the >> > BIOS as readonly for isapc. > How about changing the code to always make the ROM read/write (instead > of doing it only on isapc). Currently, if the rom is marked as > read-only, then SeaBIOS makes it read/write as the first thing it > does. So, making it read-only doesn't really serve any purpose. I don't think SeaBIOS can rely on the value of the PAM registers when it is started via a CPU reset (INIT), can it? Paolo