Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

[Mike Christie <michaelc@cs.wisc.edu>]

On 05/28/2013 06:36 AM, Vikas Chaudhary wrote:
> 
> 
> -----Original Message-----
> From: Mike Christie <michaelc@cs.wisc.edu>
> Date: Tuesday 28 May 2013 2:19 PM
> To: Vikas <vikas.chaudhary@qlogic.com>
> Cc: "jbottomley@parallels.com" <jbottomley@parallels.com>, scsi
> <linux-scsi@vger.kernel.org>, Lalit Chandivade
> <lalit.chandivade@qlogic.com>, Ravi Anand <ravi.anand@qlogic.com>, Harish
> Zunjarrao <harish.zunjarrao@qlogic.com>
> Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net
> settings
> 
>> Come on man, same comments as last patches like this :) Could you use
>> the same names that we currently use for existing params?
>>
>> Check for the inorder ones and the ones where we use en instead of
>> enabled for the postfix. Also check the others.
> 
> If we understand correctly you are suggesting to change macro postfix from
> EN to ENABLED as in attached patch "iscsi_net_param-fix1.patch".
> But we think changing old macro postfix from ENABLED to EN is better way
> to fix it.

I meant the second one. Also in the patch some of the names of sysfs
files and variables use _enabled, but for sysfs we use _en and then some
names just do not match at all.

For example some iface names like data_pdu_inorder_enabled would be
pdu_inorder_en and the data_seq_inorder_enabled would be
dataseq_inorder_en to match what the naming used in the session. There
are others that need to match like immediate data, etc. Check them
before you resubmit.