From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:55383 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755767Ab3EaVMg (ORCPT ); Fri, 31 May 2013 17:12:36 -0400 Message-ID: <51A91241.7090703@RedHat.com> Date: Fri, 31 May 2013 17:12:33 -0400 From: Steve Dickson MIME-Version: 1.0 To: Bryan Schumaker CC: Trond Myklebust , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List Subject: Re: [PATCH 05/13] NFSv4.2: Added NFS v4.2 support to the NFS client References: <1368719808-14584-1-git-send-email-SteveD@redhat.com> <1368719808-14584-6-git-send-email-SteveD@redhat.com> <51A7BBEB.60005@netapp.com> In-Reply-To: <51A7BBEB.60005@netapp.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: On 30/05/13 16:51, Bryan Schumaker wrote: >> +#if defined(CONFIG_NFS_V4_2) >> > +#define NFS4_MAX_MINOR_VERSION 2 >> > +#else >> > #if defined(CONFIG_NFS_V4_1) >> > #define NFS4_MAX_MINOR_VERSION 1 >> > #else >> > #define NFS4_MAX_MINOR_VERSION 0 >> > #endif /* CONFIG_NFS_V4_1 */ >> > +#endif /* CONFIG_NFS_V4_2 */ > Could this be done with a #elif so we don't need the nested endif-s? Sure... steved. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH 05/13] NFSv4.2: Added NFS v4.2 support to the NFS client Date: Fri, 31 May 2013 17:12:33 -0400 Message-ID: <51A91241.7090703@RedHat.com> References: <1368719808-14584-1-git-send-email-SteveD@redhat.com> <1368719808-14584-6-git-send-email-SteveD@redhat.com> <51A7BBEB.60005@netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Trond Myklebust , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List To: Bryan Schumaker Return-path: In-Reply-To: <51A7BBEB.60005-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 30/05/13 16:51, Bryan Schumaker wrote: >> +#if defined(CONFIG_NFS_V4_2) >> > +#define NFS4_MAX_MINOR_VERSION 2 >> > +#else >> > #if defined(CONFIG_NFS_V4_1) >> > #define NFS4_MAX_MINOR_VERSION 1 >> > #else >> > #define NFS4_MAX_MINOR_VERSION 0 >> > #endif /* CONFIG_NFS_V4_1 */ >> > +#endif /* CONFIG_NFS_V4_2 */ > Could this be done with a #elif so we don't need the nested endif-s? Sure... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html