From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiXMT-00040o-Dw for qemu-devel@nongnu.org; Fri, 31 May 2013 17:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiXMR-0008IZ-3I for qemu-devel@nongnu.org; Fri, 31 May 2013 17:59:49 -0400 Received: from mail-vb0-x231.google.com ([2607:f8b0:400c:c02::231]:42944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiXMQ-0008IR-Vi for qemu-devel@nongnu.org; Fri, 31 May 2013 17:59:47 -0400 Received: by mail-vb0-f49.google.com with SMTP id q13so1413871vbe.36 for ; Fri, 31 May 2013 14:59:46 -0700 (PDT) Sender: Richard Henderson Message-ID: <51A91D4E.1000804@twiddle.net> Date: Fri, 31 May 2013 14:59:42 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1369948629-2833-1-git-send-email-pbonzini@redhat.com> <1369948629-2833-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1369948629-2833-6-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/21] exec: Implement subpage_read/write via address_space_rw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Jan Kiszka , qemu-devel@nongnu.org On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > From: Jan Kiszka > > This will allow to add support for unaligned memory regions: the subpage > container region can activate unaligned support unconditionally because > the read/write handler will now ensure that accesses are split as > required by calling address_space_rw. We can furthermore drop the > special handling of RAM subpages, address_space_rw takes care of this > already. > > Signed-off-by: Jan Kiszka > Signed-off-by: Paolo Bonzini > --- > exec.c | 125 +++++++++++++++++++++++++---------------------------------------- > 1 file changed, 47 insertions(+), 78 deletions(-) I take it this is the subsequent patch that I queried from 4/. In which case both can have Reviewed-by: Richard Henderson r~