From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Brian King <brking@linux.vnet.ibm.com>, tj@kernel.org
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register
Date: Sat, 01 Jun 2013 02:37:00 +0400 [thread overview]
Message-ID: <51A9260C.20504@cogentembedded.com> (raw)
In-Reply-To: <51A89BBB.1030705@linux.vnet.ibm.com>
Hello.
On 05/31/2013 04:46 PM, Brian King wrote:
>
>> The 'ctl' field of the 'struct ata_taskfile' is not really dual purpose, i.e.
>> it is not intended for storing the alternate status register (which is mapped
>> at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
>> No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
>> register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
>> not do this as well...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Acked-by: Brian King <brking@linux.vnet.ibm.com>
>
Tejun, I would prefer that this patch be merged thru the libata tree
as my future cleanup patches depend on it.
MBR, Sergei
next prev parent reply other threads:[~2013-05-31 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 19:24 [PATCH] ipr: qc_fill_rtf() method should not store alternate status register Sergei Shtylyov
2013-05-31 12:46 ` Brian King
2013-05-31 22:37 ` Sergei Shtylyov [this message]
2013-06-02 8:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A9260C.20504@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=JBottomley@parallels.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.