From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33483)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiYDp-0002HJ-9B
	for qemu-devel@nongnu.org; Fri, 31 May 2013 18:55:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiYDm-0001z1-Tt
	for qemu-devel@nongnu.org; Fri, 31 May 2013 18:54:57 -0400
Received: from mail-vc0-f171.google.com ([209.85.220.171]:51907)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiYDm-0001yq-Op
	for qemu-devel@nongnu.org; Fri, 31 May 2013 18:54:54 -0400
Received: by mail-vc0-f171.google.com with SMTP id m16so812401vca.2
	for <qemu-devel@nongnu.org>; Fri, 31 May 2013 15:54:54 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51A92A3A.2060503@twiddle.net>
Date: Fri, 31 May 2013 15:54:50 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1369948629-2833-1-git-send-email-pbonzini@redhat.com>
	<1369948629-2833-12-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1369948629-2833-12-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/21] memory: iommu support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi.kivity@gmail.com>

On 05/30/2013 02:16 PM, Paolo Bonzini wrote:
>  struct MemoryRegion {
>      /* All fields are private - violators will be prosecuted */
>      const MemoryRegionOps *ops;
> +    const MemoryRegionIOMMUOps *iommu_ops;
>      void *opaque;
>      MemoryRegion *parent;
...
> +void memory_region_init_iommu(MemoryRegion *mr,
> +                              MemoryRegionIOMMUOps *ops,
> +                              const char *name,
> +                              uint64_t size)
> +{

Surely the incoming ops pointer should be const too?  Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~