From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Sun, 02 Jun 2013 05:07:50 +0000 Subject: Re: [PATCH v2] video: simplefb: add mode parsing function Message-Id: <51AAD326.4040809@wwwdotorg.org> List-Id: References: <1369626821-28494-1-git-send-email-acourbot@nvidia.com> <51A42ED5.2060104@wwwdotorg.org> <20130601051223.GB5189@quad.lixom.net> In-Reply-To: <20130601051223.GB5189@quad.lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 05/31/2013 11:12 PM, Olof Johansson wrote: > On Mon, May 27, 2013 at 10:13:09PM -0600, Stephen Warren wrote: >> On 05/26/2013 09:53 PM, Alexandre Courbot wrote: >>> The naming scheme of simplefb's mode is precise enough to allow building >>> the mode structure from it instead of using a static list of modes. This >>> patch introduces a function that does this. In case exotic modes that >>> cannot be represented from their name alone are needed, the static list >>> of modes is still available as a backup. ... >> As such, we should either: >> >> a) Just add new entries into the format array that already exists in the >> driver. Given David's response, this might be simplest. > > I think so too. Is this even needed? Do we have any users of the newer formats > or is it just someone trying to feature-creep this driver to make the "simple" > part of the name inaccurate? :) Alex is working on board support for a new NVIDIA board, where IIRC the bootloader sets up some 32-bit ARGB format for the panel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Sat, 01 Jun 2013 23:07:50 -0600 Subject: [PATCH v2] video: simplefb: add mode parsing function In-Reply-To: <20130601051223.GB5189@quad.lixom.net> References: <1369626821-28494-1-git-send-email-acourbot@nvidia.com> <51A42ED5.2060104@wwwdotorg.org> <20130601051223.GB5189@quad.lixom.net> Message-ID: <51AAD326.4040809@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/31/2013 11:12 PM, Olof Johansson wrote: > On Mon, May 27, 2013 at 10:13:09PM -0600, Stephen Warren wrote: >> On 05/26/2013 09:53 PM, Alexandre Courbot wrote: >>> The naming scheme of simplefb's mode is precise enough to allow building >>> the mode structure from it instead of using a static list of modes. This >>> patch introduces a function that does this. In case exotic modes that >>> cannot be represented from their name alone are needed, the static list >>> of modes is still available as a backup. ... >> As such, we should either: >> >> a) Just add new entries into the format array that already exists in the >> driver. Given David's response, this might be simplest. > > I think so too. Is this even needed? Do we have any users of the newer formats > or is it just someone trying to feature-creep this driver to make the "simple" > part of the name inaccurate? :) Alex is working on board support for a new NVIDIA board, where IIRC the bootloader sets up some 32-bit ARGB format for the panel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2] video: simplefb: add mode parsing function Date: Sat, 01 Jun 2013 23:07:50 -0600 Message-ID: <51AAD326.4040809@wwwdotorg.org> References: <1369626821-28494-1-git-send-email-acourbot@nvidia.com> <51A42ED5.2060104@wwwdotorg.org> <20130601051223.GB5189@quad.lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130601051223.GB5189-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Olof Johansson Cc: gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Clark , Alexandre Courbot , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Andrew Morton , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/31/2013 11:12 PM, Olof Johansson wrote: > On Mon, May 27, 2013 at 10:13:09PM -0600, Stephen Warren wrote: >> On 05/26/2013 09:53 PM, Alexandre Courbot wrote: >>> The naming scheme of simplefb's mode is precise enough to allow building >>> the mode structure from it instead of using a static list of modes. This >>> patch introduces a function that does this. In case exotic modes that >>> cannot be represented from their name alone are needed, the static list >>> of modes is still available as a backup. ... >> As such, we should either: >> >> a) Just add new entries into the format array that already exists in the >> driver. Given David's response, this might be simplest. > > I think so too. Is this even needed? Do we have any users of the newer formats > or is it just someone trying to feature-creep this driver to make the "simple" > part of the name inaccurate? :) Alex is working on board support for a new NVIDIA board, where IIRC the bootloader sets up some 32-bit ARGB format for the panel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420Ab3FBFID (ORCPT ); Sun, 2 Jun 2013 01:08:03 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:48740 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097Ab3FBFHy (ORCPT ); Sun, 2 Jun 2013 01:07:54 -0400 Message-ID: <51AAD326.4040809@wwwdotorg.org> Date: Sat, 01 Jun 2013 23:07:50 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Olof Johansson CC: Alexandre Courbot , Andrew Morton , Arnd Bergmann , Rob Clark , linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gnurou@gmail.com Subject: Re: [PATCH v2] video: simplefb: add mode parsing function References: <1369626821-28494-1-git-send-email-acourbot@nvidia.com> <51A42ED5.2060104@wwwdotorg.org> <20130601051223.GB5189@quad.lixom.net> In-Reply-To: <20130601051223.GB5189@quad.lixom.net> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2013 11:12 PM, Olof Johansson wrote: > On Mon, May 27, 2013 at 10:13:09PM -0600, Stephen Warren wrote: >> On 05/26/2013 09:53 PM, Alexandre Courbot wrote: >>> The naming scheme of simplefb's mode is precise enough to allow building >>> the mode structure from it instead of using a static list of modes. This >>> patch introduces a function that does this. In case exotic modes that >>> cannot be represented from their name alone are needed, the static list >>> of modes is still available as a backup. ... >> As such, we should either: >> >> a) Just add new entries into the format array that already exists in the >> driver. Given David's response, this might be simplest. > > I think so too. Is this even needed? Do we have any users of the newer formats > or is it just someone trying to feature-creep this driver to make the "simple" > part of the name inaccurate? :) Alex is working on board support for a new NVIDIA board, where IIRC the bootloader sets up some 32-bit ARGB format for the panel.