From: Oliver Hartkopp <socketcan@hartkopp.net>
To: thomas@m3y3r.de
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
Date: Sun, 02 Jun 2013 11:02:30 +0200 [thread overview]
Message-ID: <51AB0A26.6070608@hartkopp.net> (raw)
In-Reply-To: <20130601.193717.2203825358470502762.davem@davemloft.net>
Hello Thomas,
additionally to provide a proper log message it is a usual to provide the
coccinelle expression that found the source to be changed.
http://lwn.net/Articles/315686/
E.g. like these
http://marc.info/?l=linux-netdev&m=135081679626023&w=2
http://marc.info/?l=linux-netdev&m=135194048501621&w=2
http://marc.info/?l=linux-netdev&m=135306967411758&w=2
http://marc.info/?l=linux-netdev&m=135304902302198&w=2
Regards,
Oliver
On 02.06.2013 04:37, David Miller wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
> Date: Sat, 01 Jun 2013 11:59:11 +0200
>
>>
>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>
> This obscure reference to the cocci path you used to find/fix
> this problem is insufficient in detail for a commit log message.
>
> You must explain exactly what the problem is, and how you fixed
> it, in full sentences. You must make your commit header lin
> subject more appropriate as well.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-06-02 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 9:59 [PATCH] netdev: Cocci spatch "ptr_ret.spatch" Thomas Meyer
2013-06-02 2:37 ` David Miller
2013-06-02 9:02 ` Oliver Hartkopp [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-01 9:55 Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AB0A26.6070608@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.