From: Douglas Gilbert <dgilbert@interlog.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support
Date: Sun, 02 Jun 2013 13:01:57 -0400 [thread overview]
Message-ID: <51AB7A85.8060406@interlog.com> (raw)
In-Reply-To: <CAC5umyiW02vB-bbhCic=zU8CxaQY-AebQ0PCj1eTCifAUHortg@mail.gmail.com>
On 13-06-01 10:51 PM, Akinobu Mita wrote:
> 2013/5/29 Martin K. Petersen <martin.petersen@oracle.com>:
>> I have some patches pending as part of my next DIF/DIX update that makes
>> some of these things more palatable at the block/SCSI level. Akinobu
>> voiced interest in finishing the scsi_debug work on top of my code.
>
> Yes. I'm interested in that work. Before I start working on it, I would
> like to fix the problems which I found recently with virtual_gb option in
> scsi_debug. Because the change is not small and may touch the DIX/DIF
> support code, too.
>
> So Martin and Douglas, can I have your ACKs on this patch series for now?
Done.
Just doing some debugging using scsi_debug and noticed
that 'blockdev --rereadpt /dev/sdb' causes a SCSI
REPORT SUPPORTED OPERATION CODES command to be issued.
Perhaps we could add that one (and ... SUPPORTED TMFs) to
scsi_debug's code.
I was also testing setting the SWP bit in the Control
mode page and that works, even though that field is
marked as 'changeable=n'. Since scsi_debug allows all
fields in that page to be changed, perhaps they could
all be marked as changeable.
Doug Gilbert
next prev parent reply other threads:[~2013-06-02 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 8:01 [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 1/6] scsi_debug: fix invalid address passed to kunmap_atomic() Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 2/6] scsi_debug: fix incorrectly nested kmap_atomic() Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 3/6] scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1 Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 4/6] scsi_debug: invalidate protection info for unmapped region Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 5/6] scsi_debug: simplify offset calculation for dif_storep Akinobu Mita
2013-05-26 8:01 ` [PATCH v3 6/6] scsi_debug: reduce duplication between prot_verify_read and prot_verify_write Akinobu Mita
2013-05-28 19:29 ` [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support Douglas Gilbert
2013-05-28 19:40 ` Martin K. Petersen
2013-06-02 2:51 ` Akinobu Mita
2013-06-02 17:01 ` Douglas Gilbert [this message]
2013-06-07 2:35 ` Martin K. Petersen
2013-06-08 14:53 ` Akinobu Mita
2013-06-02 16:16 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AB7A85.8060406@interlog.com \
--to=dgilbert@interlog.com \
--cc=JBottomley@parallels.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.