Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013-5-31 21:19, Luiz Capitulino 写道:
> On Fri, 31 May 2013 21:04:10 +0800
> Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>
>> 于 2013-5-30 10:41, Wenchao Xia 写道:
>>> 于 2013-5-27 23:41, Kevin Wolf 写道:
>>>> Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben:
>>>>> These patches are the common part of my hmp/qmp block query series
>>>>> and Pavel's
>>>>> qmp snapshot command converion series. It mainly does following things:
>>>>> 1 move snapshot related code to block/snapshot.c, qmp and info
>>>>> dumping code to
>>>>> block/qapi.c.
>>>>> 2 better info dumping function to get rid of buffer, avoid string
>>>>> truncation.
>>>>
>>>> Posted comments on patch 1 and 4.
>>>>
>>>> Patches 2 and 3 are:
>>>> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>>>>
>>>     It seems nothing need change, Kevin, do you think it can be merged?
>>>
>>     This serial blocks mine and Pavel's work, anything need to be
>> improved? Respin with
>> -typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
>> +typedef int (*fprintf_function)(void *out, const char *fmt, ...)
>> ?
>
> As far as my review is concerned, I'm OK with your current version.
>
   Thanks Luiz. This series does code moves, so it have big chance to get
conflict when upstream changes, hope it not hang out too long... sorry
for pushing many times.

-- 
Best Regards

Wenchao Xia