From: Jason Wang <jasowang@redhat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [net-next rfc V2 6/8] macvtap: allow TUNSETIFF to create multiqueue device
Date: Mon, 03 Jun 2013 11:05:57 +0800 [thread overview]
Message-ID: <51AC0815.4030707@redhat.com> (raw)
In-Reply-To: <51A8B829.7040708@cogentembedded.com>
On 05/31/2013 10:48 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 31-05-2013 13:53, Jason Wang wrote:
>
>> Though the queue were in fact created by open(), we still need to add
>> this check
>> to be compatible with tuntap which can let mgmt software use a single
>> API to
>> manage queues. This patch only validates the device name and moves
>> the TUNSETIFF
>> to a helper.
>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> drivers/net/macvtap.c | 51
>> ++++++++++++++++++++++++++++++++++++++----------
>> 1 files changed, 40 insertions(+), 11 deletions(-)
>
>> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
>> index e76484c..eac49cb 100644
>> --- a/drivers/net/macvtap.c
>> +++ b/drivers/net/macvtap.c
>> @@ -870,6 +870,7 @@ out:
>> return ret;
>> }
>>
>> +
>
> Seems like random whitespace change.
Will remove it thanks.
>
>> static struct macvlan_dev *macvtap_get_vlan(struct macvtap_queue *q)
>> {
>> struct macvlan_dev *vlan;
> [...]
>
> WBR, Sergei
>
next prev parent reply other threads:[~2013-06-03 3:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 9:53 [net-next rfc V2 0/8] Multiqueue API for macvtap Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 1/8] macvtap: do not add self to waitqueue if doing a nonblock read Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 2/8] macvlan: switch to use IS_ENABLED() Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 3/8] macvtap: introduce macvtap_get_vlan() Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 4/8] macvlan: change the max number of queues to 16 Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 5/8] macvtap: eliminate linear search Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 6/8] macvtap: allow TUNSETIFF to create multiqueue device Jason Wang
2013-05-31 14:48 ` Sergei Shtylyov
2013-06-03 3:05 ` Jason Wang [this message]
2013-05-31 9:53 ` [net-next rfc V2 7/8] macvtap: add TUNSETQUEUE ioctl Jason Wang
2013-06-02 11:22 ` Michael S. Tsirkin
2013-06-03 5:20 ` Jason Wang
2013-06-03 11:09 ` Michael S. Tsirkin
2013-06-04 5:54 ` Jason Wang
2013-06-04 7:05 ` Michael S. Tsirkin
2013-06-05 3:01 ` Jason Wang
2013-05-31 9:53 ` [net-next rfc V2 8/8] macvtap: enable multiqueue flag Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC0815.4030707@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.