From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjORq-0003Wx-G4 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 02:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjORh-0002LY-F8 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 02:40:54 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:39685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjORh-0002LL-2F for qemu-devel@nongnu.org; Mon, 03 Jun 2013 02:40:45 -0400 Received: by mail-wi0-f181.google.com with SMTP id hi5so2309093wib.2 for ; Sun, 02 Jun 2013 23:40:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51AC3A60.5060501@redhat.com> Date: Mon, 03 Jun 2013 08:40:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1370187812-13191-1-git-send-email-pbonzini@redhat.com> <1370187812-13191-15-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] memory: return MemoryRegion from qemu_ram_addr_from_host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, Liu Ping Fan Il 02/06/2013 18:04, Peter Maydell ha scritto: > On 2 June 2013 16:43, Paolo Bonzini wrote: >> -int qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); >> +MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); >> ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr); > > This is weird, because now the _nofail and the standard > versions of this function return different things. Why > wouldn't a caller of the _nofail version potentially > need the MemoryRegion* too? I'll adjust both functions. Paolo