From: Michal Simek <monstr@monstr.eu>
To: David Miller <davem@davemloft.net>
Cc: renner@efe-gmbh.de, netdev@vger.kernel.org
Subject: Re: [PATCH] net: emaclite: Fix typo in error message
Date: Mon, 03 Jun 2013 09:53:55 +0200 [thread overview]
Message-ID: <51AC4B93.5010603@monstr.eu> (raw)
In-Reply-To: <20130531.163613.1343522161135384248.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]
On 06/01/2013 01:36 AM, David Miller wrote:
> From: Michal Simek <monstr@monstr.eu>
> Date: Fri, 31 May 2013 12:36:34 +0200
>
>> On 05/31/2013 12:30 PM, Jens Renner (EFE) wrote:
>>> s/allocal/allocate/
>>>
>>> Signed-off-by: Jens Renner <renner@efe-gmbh.de>
>>> ---
>>> drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
>>> index aa14d8a..aaadf7e 100644
>>> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
>>> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
>>> @@ -877,7 +877,7 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev)
>>>
>>> bus = mdiobus_alloc();
>>> if (!bus) {
>>> - dev_err(dev, "Failed to allocal mdiobus\n");
>>> + dev_err(dev, "Failed to allocate mdiobus\n");
>>> return -ENOMEM;
>>> }
>>
>> Acked-by: Michal Simek <monstr@monstr.eu>
>
> You're acking a patch that is corrupted by the submitter's email client
> and won't even apply :-)
:-) He has sent another email regarding to phy handling and
I have applied it, resolved conflicts on the top of my emaclite changes
and I thought that it was caused by my changes not because of corrupted
patch. That's why I have also tested it.
For this particular case, I didn't try to apply it just wanted to let you
know that I agree with this change because it fixes my typo.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-06-03 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 10:30 [PATCH] net: emaclite: Fix typo in error message Jens Renner (EFE)
2013-05-31 10:36 ` Michal Simek
2013-05-31 23:36 ` David Miller
2013-06-03 7:53 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AC4B93.5010603@monstr.eu \
--to=monstr@monstr.eu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=renner@efe-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.