From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UjRNp-0004sz-4K
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:49:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UjRNe-0000En-Bt
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:48:57 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:11903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1UjRNe-0000Ee-3Q
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 05:48:46 -0400
Message-ID: <51AC6667.5030008@huawei.com>
Date: Mon, 3 Jun 2013 11:48:23 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <51A8E339.5000500@huawei.com> <51A8E663.8020204@huawei.com>
	<51A8F670.1060601@twiddle.net>
In-Reply-To: <51A8F670.1060601@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero
	extend operations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Jani Kokkonen <Jani.Kokkonen@huawei.com>, qemu-devel@nongnu.org

On 31.05.2013 21:13, Richard Henderson wrote:
> On 05/31/2013 11:05 AM, Jani Kokkonen wrote:
>> +static inline void tcg_out_uxt(TCGContext *s, int s_bits,
>> +                               TCGReg rd, TCGReg rn)
>> +{
>> +    /* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00
>> +       of UBFM Wd, Wn, #0, #7|15 and mov */
>> +    int bits = 8 * (1 << s_bits) - 1;
>> +    tcg_out_ubfm(s, 0, rd, rn, 0, bits);
>> +}
> 
> Err, ubfm never generates mov, does it?

No, the comment is a leftover, it's wrong.

> Yes, you do that later,
> 
>> +    case INDEX_op_ext32u_i64:
>> +        tcg_out_movr(s, 0, args[0], args[1]);
>> +        break;
> 
> but the comment isn't actually correct in tcg_out_uxt, surely?
> 

right.

I was think also about the

INDEX_op_ext16u_i64 and INDEX_op_ext16u_i32,
I think I can just use ext = 0 for both when doing the UXT,
consistently to what we discussed before about trying to use
ext=0 whenever possible.

CLaudio