Re: [PATCH 0/2] librados: Add RADOS locks to the C/C++ API

[Filippos Giannakos <philipgian@grnet.gr>]

Hi Josh,

On 05/31/2013 10:44 PM, Josh Durgin wrote:
> On 05/30/2013 06:02 AM, Filippos Giannakos wrote:
>> The following patches export the RADOS advisory locks functionality to
>> the C/C++
>> librados API. The extra API calls added are inspired by the relevant
>> functions
>> of librbd.
>
> This looks good to me overall. I wonder if we should create a new
> library in the future for these kinds of things that are built on top
> of librados. Other generally useful class client operations could go
> there, as well as generally useful things built on top of librados,
> like methods for striping over many objects.

Thanks for the review. I will incorporate all your suggestions in a new
patch, which I will submit shortly.
As for the new library you mention, it is a good idea, but for now I
think that the basic RADOS locking functionality should be at the core
librados API.

King Regards,
-- 
Filippos.
<philipgian@grnet.gr>