From: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Antonio Quartulli <ordex@autistici.org>,
linux-wireless@vger.kernel.org,
Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [PATCH 1/2] nl80211: allow sending CMD_FRAME without specifying any frequency
Date: Mon, 03 Jun 2013 17:04:08 +0200 [thread overview]
Message-ID: <51ACB068.8070006@lri.fr> (raw)
In-Reply-To: <1370271547.8227.16.camel@jlt4.sipsolutions.net>
On 03/06/2013 16:59, Johannes Berg wrote:
> On Mon, 2013-06-03 at 08:39 +0200, Antonio Quartulli wrote:
>> From: Antonio Quartulli <antonio@open-mesh.com>
>>
>> Users may want to send a frame on the current channel
>> without specifying it.
>>
>> Make mgmt_tx pass a NULL channel to mac80211 if none has
>> been specified by the user.
>
> cfg80211 isn't just a mac80211 frontend ... ;-)
>
> Also, as Nicolas said, ath6kl_mgmt_tx() will crash after this patch if
> it's called in AP mode w/o a channel, so you need to think about that.
It will crash unconditionally. All ath6kl_mgmt_tx()'s code paths access
chan->center_freq at some point.
next prev parent reply other threads:[~2013-06-03 15:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 6:39 [PATCH 1/2] nl80211: allow sending CMD_FRAME without specifying any frequency Antonio Quartulli
2013-06-03 6:39 ` [PATCH 2/2] mac80211: in mgmt_tx use the current channel if none has been specified Antonio Quartulli
2013-06-03 15:01 ` Johannes Berg
2013-06-03 18:03 ` Antonio Quartulli
2013-06-03 18:16 ` Johannes Berg
2013-06-03 18:26 ` Antonio Quartulli
2013-06-03 14:07 ` [PATCH 1/2] nl80211: allow sending CMD_FRAME without specifying any frequency Nicolas Cavallari
2013-06-03 14:25 ` Antonio Quartulli
2013-06-03 14:59 ` Johannes Berg
2013-06-03 15:04 ` Nicolas Cavallari [this message]
2013-06-03 17:14 ` ath6kl_mgmt_tx with NULL chan (was Re: [PATCH 1/2] nl80211: allow sending CMD_FRAME without specifying any frequency) Antonio Quartulli
2013-06-05 9:57 ` ath6kl_mgmt_tx with NULL chan Kalle Valo
2013-06-05 10:03 ` Antonio Quartulli
2013-06-05 10:15 ` Kalle Valo
2013-06-05 11:00 ` Antonio Quartulli
2013-06-05 9:47 ` [PATCH 1/2] nl80211: allow sending CMD_FRAME without specifying any frequency Kalle Valo
2013-06-05 9:53 ` Antonio Quartulli
2013-06-05 10:05 ` Kalle Valo
2013-06-05 10:08 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACB068.8070006@lri.fr \
--to=nicolas.cavallari@lri.fr \
--cc=antonio@open-mesh.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.