All of lore.kernel.org
 help / color / mirror / Atom feed
From: john.stultz@linaro.org (John Stultz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 11/11] ARCH: mmp: support clocksource in timer
Date: Mon, 03 Jun 2013 10:07:49 -0700	[thread overview]
Message-ID: <51ACCD65.8030204@linaro.org> (raw)
In-Reply-To: <1370251845-31373-12-git-send-email-haojian.zhuang@gmail.com>

On 06/03/2013 02:30 AM, Haojian Zhuang wrote:
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index f151c6c..f429f68 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -72,6 +72,12 @@ config CLKSRC_METAG_GENERIC
>   	help
>   	  This option enables support for the Meta per-thread timers.
>   
> +config CLKSRC_MMP
> +	def_bool y if ARCH_MMP
> +	select CLKSRC_OF if OF
> +	help
> +	  This option enables support for the MMP timer.
> +
>   config CLKSRC_EXYNOS_MCT
>   	def_bool y if ARCH_EXYNOS
>   	help
>

If I'm reading the above right, CONFIG_CLKSRC_MMP is identical to 
CONFIG_ARCH_MMP, no?

Why not just use CONFIG_ARCH_MMP for configuration conditional code (and 
have that config select CLKSRC_OF if appropriate)?

Otherwise we just start adding extra unnecessary config options that 
really don't add any real meaning to things.

thanks
-john

  reply	other threads:[~2013-06-03 17:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03  9:30 [PATCH v3 00/11] update irqchip, clocksource, clk in mmp Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 01/11] irqchip: move mmp irq driver Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 02/11] irqchip: mmp: support irqchip Haojian Zhuang
2013-06-03  9:42   ` Russell King - ARM Linux
2013-06-03 10:06     ` Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 03/11] irqchip: mmp: support MULTI_IRQ_HANDLER Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 04/11] ARM: mmp: avoid to include head file in mach-mmp Haojian Zhuang
2013-06-03 22:28   ` Arnd Bergmann
2013-06-03  9:30 ` [PATCH v3 05/11] irqchip: mmp: avoid to include irqs head file Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 06/11] clocksource: mmp: move mmp timer driver Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 07/11] ARM: mmp: move timer registers into driver Haojian Zhuang
2013-06-03 22:31   ` Arnd Bergmann
2013-06-03  9:30 ` [PATCH v3 08/11] ARM: pxa: init dma debugfs in late level Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 09/11] clk: mmp: parse clock from dts Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 10/11] ARM: mmp: avoid to use cpu_is_xxx in timer Haojian Zhuang
2013-06-03 22:34   ` Arnd Bergmann
2013-06-04  1:24     ` Haojian Zhuang
2013-06-03  9:30 ` [PATCH v3 11/11] ARCH: mmp: support clocksource " Haojian Zhuang
2013-06-03 17:07   ` John Stultz [this message]
2013-06-04  1:25     ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ACCD65.8030204@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.