From: John Stultz <john.stultz@linaro.org>
To: srinivas.kandagatla@st.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [RFC] clocksource: Add clocksource drivers menu.
Date: Mon, 03 Jun 2013 11:19:31 -0700 [thread overview]
Message-ID: <51ACDE33.6060000@linaro.org> (raw)
In-Reply-To: <51AC446D.5070503@st.com>
On 06/03/2013 12:23 AM, Srinivas KANDAGATLA wrote:
> On 31/05/13 19:40, John Stultz wrote:
>> And only just now did I notice that there are user-prompts in the
>> drivers/clocksource/Kconfig.
>>
>> I suspect the platform support options can safely select the proper
>> clocksource config options without requiring the user to configure it.
>> For the most part this is the case, even so folks still introduced some
>> unnecessary clocksource config options (unnecessary as they don't prompt
>> the user, default to y and depend on another config).
>>
>> It looks like only: CLKSRC_DBX500_PRCMU &
>> CLKSRC_DBX500_PRCMU_SCHED_CLOCK prompt the user right now.
>>
>> Can you explain why its necessary the user has to be prompted here?
> The only reason is to do with "how we present *SCHED_CLOCK options"?
>
> If we make the *SCHED_CLOCK options default without prompts, then we do
> not need a menu. These options can be selected at platform level
> Kconfigs. We could possible cleanup the existing prompts.
Right. This is what I'm asking for. Since there are only two options
that prompt the user, I'm asking if there is a reason the user needs to
be prompted.
I not, we can just remove the prompts and simplify the config.
If there is a valid reason to prompt the user, then we may need to add a
menu, but I'd probably prefer we add the option in the platform menu,
rather then generate a new driver menu.
thanks
-john
prev parent reply other threads:[~2013-06-03 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 9:59 [RFC] clocksource: Add clocksource drivers menu Srinivas KANDAGATLA
2013-05-31 18:40 ` John Stultz
2013-06-03 7:23 ` Srinivas KANDAGATLA
2013-06-03 18:19 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACDE33.6060000@linaro.org \
--to=john.stultz@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@st.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.