From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Dutile Subject: Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough Date: Mon, 03 Jun 2013 16:55:13 -0400 Message-ID: <51AD02B1.8070503@redhat.com> References: <20130601121320.GC5157@irqsave.net> <51ACE340.1030406@redhat.com> <20130603192958.GB31044@irqsave.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20130603192958.GB31044-J9ArbTHlV+bR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 06/03/2013 03:29 PM, Beno=EEt Canet wrote: >>> to a guest will the consequences of a PF FLR be handled fine by QEMU an= d the >>> guest ? >>> >> the reset occurs long before the device is passed to the guest. > > I was asking this because the PF driver should reset the PF while the VF = are > used by VFIO/QEMU when the PF doesn't respond anymore. > What your VF does while your PF is being reset is PF (& VF) dependent. A 'good design' would not impact the VF operation, other than to stall it u= ntil the PF completed reset. My experience, though, is that the PF has to be br= ought up to some level of functionality to share the physical resources with the = VFs. >> The PF driver doesn't do the config space restore -- it's done in PCI co= re code. >>> files used by QEMU disappear and reappear messing the QEMU VFIO passthr= ough or >> As stated above, the devices don't disappear from the device tree, so th= ey don't >> get removed/added to the /sys(/bus/pci/...) files. >> >>> will it goes smoothly ? >>> >> it goes smoothly today.... :-/ > > Happy to read that thanks for the answer. > > Best regards > > Beno=EEt Canet > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:44732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757662Ab3FCUzZ (ORCPT ); Mon, 3 Jun 2013 16:55:25 -0400 Message-ID: <51AD02B1.8070503@redhat.com> Date: Mon, 03 Jun 2013 16:55:13 -0400 From: Don Dutile MIME-Version: 1.0 To: =?ISO-8859-1?Q?Beno=EEt_Canet?= CC: linux-pci@vger.kernel.org, qemu-devel@nongnu.org, iommu@lists.linux-foundation.org, alex.williamson@redhat.com Subject: Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough References: <20130601121320.GC5157@irqsave.net> <51ACE340.1030406@redhat.com> <20130603192958.GB31044@irqsave.net> In-Reply-To: <20130603192958.GB31044@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 06/03/2013 03:29 PM, Benoît Canet wrote: >>> to a guest will the consequences of a PF FLR be handled fine by QEMU and the >>> guest ? >>> >> the reset occurs long before the device is passed to the guest. > > I was asking this because the PF driver should reset the PF while the VF are > used by VFIO/QEMU when the PF doesn't respond anymore. > What your VF does while your PF is being reset is PF (& VF) dependent. A 'good design' would not impact the VF operation, other than to stall it until the PF completed reset. My experience, though, is that the PF has to be brought up to some level of functionality to share the physical resources with the VFs. >> The PF driver doesn't do the config space restore -- it's done in PCI core code. >>> files used by QEMU disappear and reappear messing the QEMU VFIO passthrough or >> As stated above, the devices don't disappear from the device tree, so they don't >> get removed/added to the /sys(/bus/pci/...) files. >> >>> will it goes smoothly ? >>> >> it goes smoothly today.... :-/ > > Happy to read that thanks for the answer. > > Best regards > > Benoît Canet > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ujbms-0008WA-M7 for qemu-devel@nongnu.org; Mon, 03 Jun 2013 16:55:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ujbmn-0003xY-Ty for qemu-devel@nongnu.org; Mon, 03 Jun 2013 16:55:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ujbmn-0003xO-LH for qemu-devel@nongnu.org; Mon, 03 Jun 2013 16:55:25 -0400 Message-ID: <51AD02B1.8070503@redhat.com> Date: Mon, 03 Jun 2013 16:55:13 -0400 From: Don Dutile MIME-Version: 1.0 References: <20130601121320.GC5157@irqsave.net> <51ACE340.1030406@redhat.com> <20130603192958.GB31044@irqsave.net> In-Reply-To: <20130603192958.GB31044@irqsave.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Beno=EEt_Canet?= Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org, alex.williamson@redhat.com, qemu-devel@nongnu.org On 06/03/2013 03:29 PM, Beno=EEt Canet wrote: >>> to a guest will the consequences of a PF FLR be handled fine by QEMU = and the >>> guest ? >>> >> the reset occurs long before the device is passed to the guest. > > I was asking this because the PF driver should reset the PF while the V= F are > used by VFIO/QEMU when the PF doesn't respond anymore. > What your VF does while your PF is being reset is PF (& VF) dependent. A 'good design' would not impact the VF operation, other than to stall it= until the PF completed reset. My experience, though, is that the PF has to be = brought up to some level of functionality to share the physical resources with th= e VFs. >> The PF driver doesn't do the config space restore -- it's done in PCI = core code. >>> files used by QEMU disappear and reappear messing the QEMU VFIO passt= hrough or >> As stated above, the devices don't disappear from the device tree, so = they don't >> get removed/added to the /sys(/bus/pci/...) files. >> >>> will it goes smoothly ? >>> >> it goes smoothly today.... :-/ > > Happy to read that thanks for the answer. > > Best regards > > Beno=EEt Canet > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html